src/jsregexp.cc - Issue 207613005: No longer OOM on invalid string length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 207613005: No longer OOM on invalid string length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebase + addressed nits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/jsregexp.cc

diff --git a/src/jsregexp.cc b/src/jsregexp.cc

index 012c251e21d3035d3a290eb88f635851888f06f2..830dd7b35ef3576f0153ae8f1c8e279eeb8f8988 100644

--- a/src/jsregexp.cc

+++ b/src/jsregexp.cc

@@ -466,6 +466,7 @@ bool RegExpImpl::CompileIrregexp(Handle<JSRegExp> re,

// Unable to compile regexp.

Handle<String> error_message =

isolate->factory()->NewStringFromUtf8(CStrVector(result.error_message));

+ ASSERT(!error_message.is_null());

CreateRegExpErrorObjectAndThrow(re, is_ascii, error_message, isolate);

return false;

}

« no previous file with comments | « src/json-stringifier.h ('k') | src/liveedit.cc » ('j') | no next file with comments »