src/contexts.cc - Issue 207613005: No longer OOM on invalid string length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 207613005: No longer OOM on invalid string length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebase + addressed nits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index ada6e049a67727baa66362f198497cbaa7ed1f03..33d47e9c4bb73eeceec550c0116cea6c6cf5db51 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -368,7 +368,7 @@ Handle<Object> Context::ErrorMessageForCodeGenerationFromStrings() {

Handle<Object> result(error_message_for_code_gen_from_strings(),

GetIsolate());

if (!result->IsUndefined()) return result;

- return GetIsolate()->factory()->NewStringFromAscii(i::CStrVector(

+ return GetIsolate()->factory()->NewStringFromOneByte(STATIC_ASCII_VECTOR(

"Code generation from strings disallowed for this context"));

}

« no previous file with comments | « src/bootstrapper.cc ('k') | src/debug.cc » ('j') | no next file with comments »