Do not left-trim arrays when concurrent sweeping is active.

Do not left-trim arrays when concurrent sweeping is active.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20238

[Michael Starzinger, 2014-03-24 12:21:35]

LGTM with comments.

https://codereview.chromium.org/207613004/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/207613004/diff/1/src/builtins.cc#newcode957
src/builtins.cc:957: // This is the slow path. We are going to move the elemetns
to the left
nit: s/elemetns/elements/

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc#newcode679
src/mark-compact.cc:679: }
nit: Indentation is off.

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h#newcode741
src/mark-compact.h:741: bool CanMoveObjectStart(HeapObject* object);
nit: Shouldn't this actually be a predicate on the Heap class instead of the
MarkCompactCollector class?

https://codereview.chromium.org/207613004/diff/1/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/207613004/diff/1/src/spaces.h#newcode478
src/spaces.h:478: PARALLEL_SWEEPING_FINALIZE,
Please add a comment explaining the semantics of this new state above. Also
please leave a comment that the order of the constants is important because we
use them for range checks.

[Hannes Payer (out of office), 2014-03-25 11:41:07]

https://codereview.chromium.org/207613004/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/207613004/diff/1/src/builtins.cc#newcode957
src/builtins.cc:957: // This is the slow path. We are going to move the elemetns
to the left
On 2014/03/24 12:21:35, Michael Starzinger wrote:
> nit: s/elemetns/elements/

Done.

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc#newcode679
src/mark-compact.cc:679: }
On 2014/03/24 12:21:35, Michael Starzinger wrote:
> nit: Indentation is off.

Done.

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h#newcode741
src/mark-compact.h:741: bool CanMoveObjectStart(HeapObject* object);
On 2014/03/24 12:21:35, Michael Starzinger wrote:
> nit: Shouldn't this actually be a predicate on the Heap class instead of the
> MarkCompactCollector class?

Done.

https://codereview.chromium.org/207613004/diff/1/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/207613004/diff/1/src/spaces.h#newcode478
src/spaces.h:478: PARALLEL_SWEEPING_FINALIZE,
On 2014/03/24 12:21:35, Michael Starzinger wrote:
> Please add a comment explaining the semantics of this new state above. Also
> please leave a comment that the order of the constants is important because we
> use them for range checks.

Done.

[Hannes Payer (out of office), 2014-03-25 11:57:34]

Committed patchset #2 manually as r20238 (presubmit successful).