Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: extensions/browser/extension_registry_unittest.cc

Issue 207613002: Cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED usage in MediaScanManager. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/extension_registry.h" 5 #include "extensions/browser/extension_registry.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "extensions/browser/extension_registry_observer.h" 10 #include "extensions/browser/extension_registry_observer.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 virtual void OnExtensionUnloaded(const Extension* extension) OVERRIDE { 50 virtual void OnExtensionUnloaded(const Extension* extension) OVERRIDE {
51 unloaded_.push_back(extension); 51 unloaded_.push_back(extension);
52 } 52 }
53 53
54 ExtensionList loaded_; 54 ExtensionList loaded_;
55 ExtensionList unloaded_; 55 ExtensionList unloaded_;
56 }; 56 };
57 57
58 TEST_F(ExtensionRegistryTest, FillAndClearRegistry) { 58 TEST_F(ExtensionRegistryTest, FillAndClearRegistry) {
59 ExtensionRegistry registry; 59 ExtensionRegistry registry(NULL);
60 scoped_refptr<Extension> extension1 = test_util::CreateExtensionWithID("id1"); 60 scoped_refptr<Extension> extension1 = test_util::CreateExtensionWithID("id1");
61 scoped_refptr<Extension> extension2 = test_util::CreateExtensionWithID("id2"); 61 scoped_refptr<Extension> extension2 = test_util::CreateExtensionWithID("id2");
62 scoped_refptr<Extension> extension3 = test_util::CreateExtensionWithID("id3"); 62 scoped_refptr<Extension> extension3 = test_util::CreateExtensionWithID("id3");
63 scoped_refptr<Extension> extension4 = test_util::CreateExtensionWithID("id4"); 63 scoped_refptr<Extension> extension4 = test_util::CreateExtensionWithID("id4");
64 64
65 // All the sets start empty. 65 // All the sets start empty.
66 EXPECT_EQ(0u, registry.enabled_extensions().size()); 66 EXPECT_EQ(0u, registry.enabled_extensions().size());
67 EXPECT_EQ(0u, registry.disabled_extensions().size()); 67 EXPECT_EQ(0u, registry.disabled_extensions().size());
68 EXPECT_EQ(0u, registry.terminated_extensions().size()); 68 EXPECT_EQ(0u, registry.terminated_extensions().size());
69 EXPECT_EQ(0u, registry.blacklisted_extensions().size()); 69 EXPECT_EQ(0u, registry.blacklisted_extensions().size());
(...skipping 13 matching lines...) Expand all
83 registry.ClearAll(); 83 registry.ClearAll();
84 84
85 EXPECT_EQ(0u, registry.enabled_extensions().size()); 85 EXPECT_EQ(0u, registry.enabled_extensions().size());
86 EXPECT_EQ(0u, registry.disabled_extensions().size()); 86 EXPECT_EQ(0u, registry.disabled_extensions().size());
87 EXPECT_EQ(0u, registry.terminated_extensions().size()); 87 EXPECT_EQ(0u, registry.terminated_extensions().size());
88 EXPECT_EQ(0u, registry.blacklisted_extensions().size()); 88 EXPECT_EQ(0u, registry.blacklisted_extensions().size());
89 } 89 }
90 90
91 // A simple test of adding and removing things from sets. 91 // A simple test of adding and removing things from sets.
92 TEST_F(ExtensionRegistryTest, AddAndRemoveExtensionFromRegistry) { 92 TEST_F(ExtensionRegistryTest, AddAndRemoveExtensionFromRegistry) {
93 ExtensionRegistry registry; 93 ExtensionRegistry registry(NULL);
94 94
95 // Adding an extension works. 95 // Adding an extension works.
96 scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id"); 96 scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id");
97 EXPECT_TRUE(registry.AddEnabled(extension)); 97 EXPECT_TRUE(registry.AddEnabled(extension));
98 EXPECT_EQ(1u, registry.enabled_extensions().size()); 98 EXPECT_EQ(1u, registry.enabled_extensions().size());
99 99
100 // The extension was only added to one set. 100 // The extension was only added to one set.
101 EXPECT_EQ(0u, registry.disabled_extensions().size()); 101 EXPECT_EQ(0u, registry.disabled_extensions().size());
102 EXPECT_EQ(0u, registry.terminated_extensions().size()); 102 EXPECT_EQ(0u, registry.terminated_extensions().size());
103 EXPECT_EQ(0u, registry.blacklisted_extensions().size()); 103 EXPECT_EQ(0u, registry.blacklisted_extensions().size());
104 104
105 // Removing an extension works. 105 // Removing an extension works.
106 EXPECT_TRUE(registry.RemoveEnabled(extension->id())); 106 EXPECT_TRUE(registry.RemoveEnabled(extension->id()));
107 EXPECT_EQ(0u, registry.enabled_extensions().size()); 107 EXPECT_EQ(0u, registry.enabled_extensions().size());
108 108
109 // Trying to remove an extension that isn't in the set fails cleanly. 109 // Trying to remove an extension that isn't in the set fails cleanly.
110 EXPECT_FALSE(registry.RemoveEnabled(extension->id())); 110 EXPECT_FALSE(registry.RemoveEnabled(extension->id()));
111 } 111 }
112 112
113 TEST_F(ExtensionRegistryTest, AddExtensionToRegistryTwice) { 113 TEST_F(ExtensionRegistryTest, AddExtensionToRegistryTwice) {
114 ExtensionRegistry registry; 114 ExtensionRegistry registry(NULL);
115 scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id"); 115 scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id");
116 116
117 // An extension can exist in two sets at once. It would be nice to eliminate 117 // An extension can exist in two sets at once. It would be nice to eliminate
118 // this functionality, but some users of ExtensionRegistry need it. 118 // this functionality, but some users of ExtensionRegistry need it.
119 EXPECT_TRUE(registry.AddEnabled(extension)); 119 EXPECT_TRUE(registry.AddEnabled(extension));
120 EXPECT_TRUE(registry.AddDisabled(extension)); 120 EXPECT_TRUE(registry.AddDisabled(extension));
121 121
122 EXPECT_EQ(1u, registry.enabled_extensions().size()); 122 EXPECT_EQ(1u, registry.enabled_extensions().size());
123 EXPECT_EQ(1u, registry.disabled_extensions().size()); 123 EXPECT_EQ(1u, registry.disabled_extensions().size());
124 EXPECT_EQ(0u, registry.terminated_extensions().size()); 124 EXPECT_EQ(0u, registry.terminated_extensions().size());
125 EXPECT_EQ(0u, registry.blacklisted_extensions().size()); 125 EXPECT_EQ(0u, registry.blacklisted_extensions().size());
126 } 126 }
127 127
128 TEST_F(ExtensionRegistryTest, GetExtensionById) { 128 TEST_F(ExtensionRegistryTest, GetExtensionById) {
129 ExtensionRegistry registry; 129 ExtensionRegistry registry(NULL);
130 130
131 // Trying to get an extension fails cleanly when the sets are empty. 131 // Trying to get an extension fails cleanly when the sets are empty.
132 EXPECT_FALSE( 132 EXPECT_FALSE(
133 registry.GetExtensionById("id", ExtensionRegistry::EVERYTHING)); 133 registry.GetExtensionById("id", ExtensionRegistry::EVERYTHING));
134 134
135 scoped_refptr<Extension> enabled = 135 scoped_refptr<Extension> enabled =
136 test_util::CreateExtensionWithID("enabled"); 136 test_util::CreateExtensionWithID("enabled");
137 scoped_refptr<Extension> disabled = 137 scoped_refptr<Extension> disabled =
138 test_util::CreateExtensionWithID("disabled"); 138 test_util::CreateExtensionWithID("disabled");
139 scoped_refptr<Extension> terminated = 139 scoped_refptr<Extension> terminated =
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // Enabled can be found with multiple flags set. 198 // Enabled can be found with multiple flags set.
199 EXPECT_TRUE(registry.GetExtensionById( 199 EXPECT_TRUE(registry.GetExtensionById(
200 "enabled", ExtensionRegistry::ENABLED | ExtensionRegistry::TERMINATED)); 200 "enabled", ExtensionRegistry::ENABLED | ExtensionRegistry::TERMINATED));
201 201
202 // Enabled isn't found if the wrong flags are set. 202 // Enabled isn't found if the wrong flags are set.
203 EXPECT_FALSE(registry.GetExtensionById( 203 EXPECT_FALSE(registry.GetExtensionById(
204 "enabled", ExtensionRegistry::DISABLED | ExtensionRegistry::BLACKLISTED)); 204 "enabled", ExtensionRegistry::DISABLED | ExtensionRegistry::BLACKLISTED));
205 } 205 }
206 206
207 TEST_F(ExtensionRegistryTest, Observer) { 207 TEST_F(ExtensionRegistryTest, Observer) {
208 ExtensionRegistry registry; 208 ExtensionRegistry registry(NULL);
209 TestObserver observer; 209 TestObserver observer;
210 registry.AddObserver(&observer); 210 registry.AddObserver(&observer);
211 211
212 EXPECT_TRUE(observer.loaded().empty()); 212 EXPECT_TRUE(observer.loaded().empty());
213 EXPECT_TRUE(observer.unloaded().empty()); 213 EXPECT_TRUE(observer.unloaded().empty());
214 214
215 scoped_refptr<const Extension> extension = 215 scoped_refptr<const Extension> extension =
216 test_util::CreateExtensionWithID("id"); 216 test_util::CreateExtensionWithID("id");
217 217
218 registry.AddEnabled(extension); 218 registry.AddEnabled(extension);
219 registry.TriggerOnLoaded(extension); 219 registry.TriggerOnLoaded(extension);
220 220
221 EXPECT_TRUE(HasSingleExtension(observer.loaded(), extension.get())); 221 EXPECT_TRUE(HasSingleExtension(observer.loaded(), extension.get()));
222 EXPECT_TRUE(observer.unloaded().empty()); 222 EXPECT_TRUE(observer.unloaded().empty());
223 observer.Reset(); 223 observer.Reset();
224 224
225 registry.RemoveEnabled(extension->id()); 225 registry.RemoveEnabled(extension->id());
226 registry.TriggerOnUnloaded(extension); 226 registry.TriggerOnUnloaded(extension);
227 227
228 EXPECT_TRUE(observer.loaded().empty()); 228 EXPECT_TRUE(observer.loaded().empty());
229 EXPECT_TRUE(HasSingleExtension(observer.unloaded(), extension.get())); 229 EXPECT_TRUE(HasSingleExtension(observer.unloaded(), extension.get()));
230 observer.Reset(); 230 observer.Reset();
231 231
232 registry.RemoveObserver(&observer); 232 registry.RemoveObserver(&observer);
233 } 233 }
234 234
235 } // namespace 235 } // namespace
236 } // namespace extensions 236 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698