Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3209)

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

Issue 2076093004: [Extensions UI] Handle multiple warning bubbles racing to show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
index 248cb1ff1ba047cc10a88b3595959f59a455fbcd..e25e4e55067170457c1bdc5d35d5b3e4a9154a01 100644
--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
@@ -53,9 +53,9 @@ class ExtensionMessageBubbleViewBrowserTest
private:
// ExtensionMessageBubbleBrowserTest:
- void CheckBubble(Browser* browser, AnchorPosition anchor) override;
- void CloseBubble(Browser* browser) override;
- void CheckBubbleIsNotPresent(Browser* browser) override;
+ void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override;
+ void CloseBubbleNative(Browser* browser) override;
+ void CheckBubbleIsNotPresentNative(Browser* browser) override;
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleViewBrowserTest);
};
@@ -69,8 +69,9 @@ class ExtensionMessageBubbleViewBrowserTestRedesign
}
};
-void ExtensionMessageBubbleViewBrowserTest::CheckBubble(Browser* browser,
- AnchorPosition anchor) {
+void ExtensionMessageBubbleViewBrowserTest::CheckBubbleNative(
+ Browser* browser,
+ AnchorPosition anchor) {
ToolbarView* toolbar_view = GetToolbarViewForBrowser(browser);
BrowserActionsContainer* container = toolbar_view->browser_actions();
views::BubbleDialogDelegateView* bubble = container->active_bubble();
@@ -87,7 +88,8 @@ void ExtensionMessageBubbleViewBrowserTest::CheckBubble(Browser* browser,
CheckBubbleAndReferenceView(bubble, anchor_view);
}
-void ExtensionMessageBubbleViewBrowserTest::CloseBubble(Browser* browser) {
+void ExtensionMessageBubbleViewBrowserTest::CloseBubbleNative(
+ Browser* browser) {
BrowserActionsContainer* container =
GetToolbarViewForBrowser(browser)->browser_actions();
views::BubbleDialogDelegateView* bubble = container->active_bubble();
@@ -96,7 +98,7 @@ void ExtensionMessageBubbleViewBrowserTest::CloseBubble(Browser* browser) {
EXPECT_EQ(nullptr, container->active_bubble());
}
-void ExtensionMessageBubbleViewBrowserTest::CheckBubbleIsNotPresent(
+void ExtensionMessageBubbleViewBrowserTest::CheckBubbleIsNotPresentNative(
Browser* browser) {
EXPECT_EQ(
nullptr,
@@ -156,3 +158,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestRedesign,
TestControlledSearchBubbleShown();
}
#endif // defined(OS_WIN)
+
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
+ TestBubbleWithMultipleWindows) {
+ TestBubbleWithMultipleWindows();
+}
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698