Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller.h

Issue 2076093004: [Extensions UI] Handle multiple warning bubbles racing to show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_message_bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_message_bubble_controller.h
diff --git a/chrome/browser/extensions/extension_message_bubble_controller.h b/chrome/browser/extensions/extension_message_bubble_controller.h
index f125d481d22a3f5503f788793e0de01f4673ce05..2af76e9781686dc06213f339c6ab91ade1e5d646 100644
--- a/chrome/browser/extensions/extension_message_bubble_controller.h
+++ b/chrome/browser/extensions/extension_message_bubble_controller.h
@@ -18,6 +18,7 @@
class Browser;
class BrowserList;
class ExtensionService;
+class ToolbarActionsModel;
class Profile;
namespace extensions {
@@ -160,6 +161,9 @@ class ExtensionMessageBubbleController : public chrome::BrowserListObserver {
virtual void OnBubbleDismiss(bool dismissed_by_deactivation);
virtual void OnLinkClicked();
+ // Sets this bubble as the active bubble being shown.
+ void SetIsActiveBubble();
+
void ClearProfileListForTesting();
static void set_should_ignore_learn_more_for_testing(
@@ -183,6 +187,9 @@ class ExtensionMessageBubbleController : public chrome::BrowserListObserver {
// A weak pointer to the Browser we are associated with. Not owned by us.
Browser* browser_;
+ // The associated ToolbarActionsModel. Not owned.
+ ToolbarActionsModel* model_;
+
// The list of extensions found.
ExtensionIdList extension_list_;
@@ -196,7 +203,10 @@ class ExtensionMessageBubbleController : public chrome::BrowserListObserver {
bool initialized_;
// Whether or not the bubble is highlighting extensions.
- bool did_highlight_;
+ bool is_highlighting_;
+
+ // Whether or not this bubble is the active bubble being shown.
+ bool is_active_bubble_;
ScopedObserver<BrowserList, BrowserListObserver> browser_list_observer_;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_message_bubble_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698