[Extensions UI] Handle multiple warning bubbles racing to show

chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h"
 
 #include "base/bind_helpers.h"
 #include "base/run_loop.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/extension_action_test_util.h"
@@ skipping 47 matching lines @@
     "  'manifest_version': 2,\n"
     "  'description': 'controls settings',\n"
     "  'chrome_settings_overrides': {\n"
     "    %s\n"
     "  }\n"
     "}", settings_override_value.c_str());
   custom_extension_dir_->WriteManifestWithSingleQuotes(manifest);
   ASSERT_TRUE(LoadExtension(custom_extension_dir_->unpacked_path()));
 }
 
+void ExtensionMessageBubbleBrowserTest::CheckBubble(
+    Browser* browser,
+    AnchorPosition position,
+    bool should_be_highlighting) {
+  EXPECT_EQ(should_be_highlighting, toolbar_model()->is_highlighting());
+  EXPECT_TRUE(toolbar_model()->has_active_bubble());
+  EXPECT_TRUE(browser->window()->GetToolbarActionsBar()->is_showing_bubble());
+  CheckBubbleNative(browser, position);
+}
+
+void ExtensionMessageBubbleBrowserTest::CheckBubbleIsNotPresent(
+    Browser* browser,
+    bool should_profile_have_bubble,
+    bool should_be_highlighting) {
+  // We should never be highlighting without an active bubble.
+  ASSERT_TRUE(!should_be_highlighting || should_profile_have_bubble);
+  EXPECT_EQ(should_be_highlighting, toolbar_model()->is_highlighting());
+  EXPECT_EQ(should_profile_have_bubble, toolbar_model()->has_active_bubble());
+  EXPECT_FALSE(browser->window()->GetToolbarActionsBar()->is_showing_bubble());
+  CheckBubbleIsNotPresentNative(browser);
+}
+
+void ExtensionMessageBubbleBrowserTest::CloseBubble(Browser* browser) {
+  CloseBubbleNative(browser);
+  base::RunLoop().RunUntilIdle();
+  CheckBubbleIsNotPresent(browser, false, false);
+}
+
 void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToExtensionAction() {
   scoped_refptr<const extensions::Extension> action_extension =
       extensions::extension_action_test_util::CreateActionExtension(
           "action_extension",
           extensions::extension_action_test_util::BROWSER_ACTION,
           extensions::Manifest::UNPACKED);
   extension_service()->AddExtension(action_extension.get());
 
   Browser* second_browser = new Browser(Browser::CreateParams(profile()));
   base::RunLoop().RunUntilIdle();
 
-  CheckBubble(second_browser, ANCHOR_BROWSER_ACTION);
+  CheckBubble(second_browser, ANCHOR_BROWSER_ACTION, true);
   CloseBubble(second_browser);
 }
 
 void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToAppMenu() {
   scoped_refptr<const extensions::Extension> no_action_extension =
       extensions::extension_action_test_util::CreateActionExtension(
           "no_action_extension",
           extensions::extension_action_test_util::NO_ACTION,
           extensions::Manifest::UNPACKED);
   extension_service()->AddExtension(no_action_extension.get());
   Browser* second_browser = new Browser(Browser::CreateParams(profile()));
   base::RunLoop().RunUntilIdle();
-  CheckBubble(second_browser, ANCHOR_APP_MENU);
+  CheckBubble(second_browser, ANCHOR_APP_MENU, false);
   CloseBubble(second_browser);
 }
 
 void ExtensionMessageBubbleBrowserTest::
     TestBubbleAnchoredToAppMenuWithOtherAction() {
   scoped_refptr<const extensions::Extension> no_action_extension =
       extensions::extension_action_test_util::CreateActionExtension(
           "no_action_extension",
           extensions::extension_action_test_util::NO_ACTION,
           extensions::Manifest::UNPACKED);
   extension_service()->AddExtension(no_action_extension.get());
 
   scoped_refptr<const extensions::Extension> action_extension =
       extensions::extension_action_test_util::CreateActionExtension(
           "action_extension",
           extensions::extension_action_test_util::BROWSER_ACTION,
           extensions::Manifest::INTERNAL);
   extension_service()->AddExtension(action_extension.get());
 
   Browser* second_browser = new Browser(Browser::CreateParams(profile()));
   base::RunLoop().RunUntilIdle();
 
-  CheckBubble(second_browser, ANCHOR_APP_MENU);
+  CheckBubble(second_browser, ANCHOR_APP_MENU, false);
   CloseBubble(second_browser);
 }
 
 void ExtensionMessageBubbleBrowserTest::TestUninstallDangerousExtension() {
   // Load an extension that overrides the proxy setting.
   ExtensionTestMessageListener listener("registered", false);
   const extensions::Extension* extension =
       LoadExtension(test_data_dir_.AppendASCII("api_test")
                         .AppendASCII("proxy")
                         .AppendASCII("register"));
   // Wait for it to complete.
   listener.WaitUntilSatisfied();
 
   // Create a second browser with the extension installed - the bubble will be
   // set to show.
   Browser* second_browser = new Browser(Browser::CreateParams(profile()));
   ASSERT_TRUE(second_browser);
   // Uninstall the extension before the bubble is shown. This should not crash,
   // and the bubble shouldn't be shown.
   extension_service()->UninstallExtension(
       extension->id(), extensions::UNINSTALL_REASON_FOR_TESTING,
       base::Bind(&base::DoNothing), nullptr);
   base::RunLoop().RunUntilIdle();
-  CheckBubbleIsNotPresent(second_browser);
+  CheckBubbleIsNotPresent(second_browser, false, false);
 }
 
 void ExtensionMessageBubbleBrowserTest::PreBubbleShowsOnStartup() {
   LoadExtension(test_data_dir_.AppendASCII("good_unpacked"));
 }
 
 void ExtensionMessageBubbleBrowserTest::TestBubbleShowsOnStartup() {
   base::RunLoop().RunUntilIdle();
-  CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
+  CheckBubble(browser(), ANCHOR_BROWSER_ACTION, true);
   CloseBubble(browser());
 }
 
 void ExtensionMessageBubbleBrowserTest::TestDevModeBubbleIsntShownTwice() {
   scoped_refptr<const extensions::Extension> action_extension =
       extensions::extension_action_test_util::CreateActionExtension(
           "action_extension",
           extensions::extension_action_test_util::BROWSER_ACTION,
           extensions::Manifest::UNPACKED);
   extension_service()->AddExtension(action_extension.get());
 
   Browser* second_browser = new Browser(Browser::CreateParams(profile()));
   base::RunLoop().RunUntilIdle();
 
-  CheckBubble(second_browser, ANCHOR_BROWSER_ACTION);
+  CheckBubble(second_browser, ANCHOR_BROWSER_ACTION, true);
   CloseBubble(second_browser);
   base::RunLoop().RunUntilIdle();
 
   // The bubble was already shown, so it shouldn't be shown again.
   Browser* third_browser = new Browser(Browser::CreateParams(profile()));
   base::RunLoop().RunUntilIdle();
-  CheckBubbleIsNotPresent(third_browser);
+  CheckBubbleIsNotPresent(third_browser, false, false);
 }
 
 void ExtensionMessageBubbleBrowserTest::TestControlledNewTabPageBubbleShown() {
   ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("api_test")
                                           .AppendASCII("override")
                                           .AppendASCII("newtab")));
-  CheckBubbleIsNotPresent(browser());
+  CheckBubbleIsNotPresent(browser(), false, false);
   chrome::NewTab(browser());
   base::RunLoop().RunUntilIdle();
-  CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
+  CheckBubble(browser(), ANCHOR_BROWSER_ACTION, false);
   CloseBubble(browser());
 }
 
 void ExtensionMessageBubbleBrowserTest::TestControlledHomeBubbleShown() {
   browser()->profile()->GetPrefs()->SetBoolean(prefs::kShowHomeButton, true);
 
   const char kHomePage[] = "'homepage': 'https://www.google.com'\n";
   AddSettingsOverrideExtension(kHomePage);
 
-  CheckBubbleIsNotPresent(browser());
+  CheckBubbleIsNotPresent(browser(), false, false);
 
   chrome::ExecuteCommandWithDisposition(browser(),
                                         IDC_HOME, NEW_FOREGROUND_TAB);
   base::RunLoop().RunUntilIdle();
 
-  CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
+  CheckBubble(browser(), ANCHOR_BROWSER_ACTION, false);
   CloseBubble(browser());
 }
 
 void ExtensionMessageBubbleBrowserTest::TestControlledSearchBubbleShown() {
   const char kSearchProvider[] =
       "'search_provider': {\n"
       "  'search_url': 'https://www.google.com/search?q={searchTerms}',\n"
       "  'is_default': true,\n"
       "  'favicon_url': 'https://www.google.com/favicon.icon',\n"
       "  'keyword': 'TheGoogs',\n"
       "  'name': 'Google',\n"
       "  'encoding': 'UTF-8'\n"
       "}\n";
   AddSettingsOverrideExtension(kSearchProvider);
 
-  CheckBubbleIsNotPresent(browser());
+  CheckBubbleIsNotPresent(browser(), false, false);
 
   OmniboxView* omnibox =
       browser()->window()->GetLocationBar()->GetOmniboxView();
   omnibox->OnBeforePossibleChange();
   omnibox->SetUserText(base::ASCIIToUTF16("search for this"));
   omnibox->OnAfterPossibleChange(true);
   omnibox->model()->AcceptInput(CURRENT_TAB, false);
   base::RunLoop().RunUntilIdle();
 
-  CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
+  CheckBubble(browser(), ANCHOR_BROWSER_ACTION, false);
   CloseBubble(browser());
 }
+
+void ExtensionMessageBubbleBrowserTest::TestBubbleWithMultipleWindows() {
+  CheckBubbleIsNotPresent(browser(), false, false);
+  LoadExtension(test_data_dir_.AppendASCII("good_unpacked"));
+  Browser* second_browser = new Browser(Browser::CreateParams(profile()));
+  Browser* third_browser = new Browser(Browser::CreateParams(profile()));
+  Browser* fourth_browser = new Browser(Browser::CreateParams(profile()));
+  base::RunLoop().RunUntilIdle();
+  CheckBubble(second_browser, ANCHOR_BROWSER_ACTION, true);
+  // Even though the bubble isn't present on these browser windows, highlighting
+  // is per-profile.
+  CheckBubbleIsNotPresent(browser(), true, true);
+  CheckBubbleIsNotPresent(third_browser, true, true);
+  CheckBubbleIsNotPresent(fourth_browser, true, true);
+  CloseBubble(second_browser);
+}