MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org

Committed: https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325
Cr-Commit-Position: refs/heads/master@{#400528}

[Dan Beam, 2016-06-17 18:22:12]

Description was changed from

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes.

But...

ONCE AND FOR ALL

BUG=620370
R=michaelpg@chromium.org
==========

to

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL

BUG=620370
R=michaelpg@chromium.org
==========

[Dan Beam, 2016-06-17 18:22:20]

Description was changed from

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL

BUG=620370
R=michaelpg@chromium.org
==========

to

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=michaelpg@chromium.org
==========

[Dan Beam, 2016-06-17 20:39:35]

dbeam@chromium.org changed reviewers:
+ groby@chromium.org
- michaelpg@chromium.org

[Dan Beam, 2016-06-17 20:39:44]

Description was changed from

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=michaelpg@chromium.org
==========

to

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org
==========

[groby-ooo-7-16, 2016-06-17 20:47:05]

LGTM - create ALL the MdSettingsUIs!

[michaelpg, 2016-06-17 20:57:11]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-06-17 20:57:12]

lgtm

https://codereview.chromium.org/2076083003/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2076083003/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_ui.cc:91: CHECK(url.GetOrigin() ==
GURL(chrome::kChromeUISettingsURL).GetOrigin() ||
it would be nice if we could just crash the tab instead of the entire browser.
Is that possible somehow?

[Dan Beam, 2016-06-17 21:04:12]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-06-17 21:04:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076083003/20001

[Dan Beam, 2016-06-17 21:05:15]

https://codereview.chromium.org/2076083003/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2076083003/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_ui.cc:91: CHECK(url.GetOrigin() ==
GURL(chrome::kChromeUISettingsURL).GetOrigin() ||
On 2016/06/17 20:57:11, michaelpg wrote:
> it would be nice if we could just crash the tab instead of the entire browser.
> Is that possible somehow?

CHECK() is stuff that should never happen, so I don't think it's worth handling
it in a "better" way

[commit-bot: I haz the power, 2016-06-17 21:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 21:46:49]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Dan Beam, 2016-06-17 21:49:56]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-06-17 21:49:56]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2076083003/#ps40001
(title: "!android")

[commit-bot: I haz the power, 2016-06-17 21:50:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076083003/40001

[commit-bot: I haz the power, 2016-06-17 22:30:02]

Description was changed from

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org
==========

to

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org
==========

[commit-bot: I haz the power, 2016-06-17 22:30:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-17 22:31:58]

Description was changed from

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org
==========

to

==========
MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.

But...

ONCE AND FOR ALL!

BUG=620370
R=groby@chromium.org

Committed: https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325
Cr-Commit-Position: refs/heads/master@{#400528}
==========

[commit-bot: I haz the power, 2016-06-17 22:31:59]

Patchset 3 (id:??) landed as
https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325
Cr-Commit-Position: refs/heads/master@{#400528}

[benwells, 2016-06-20 10:59:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2082563002/ by benwells@chromium.org.

The reason for reverting is: New test is failing on DrMemory :(

First failing build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%2...

Sample test output:
MdSettingsBrowserTest.BackForwardDoesntCrash:
Did not complete..