Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 2076063002: Clarify that WebContents::GetLastCommittedURL returns the virtual URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/browser/web_contents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 20 matching lines...) Expand all
31 public: 31 public:
32 virtual ~NavigationHandle() {} 32 virtual ~NavigationHandle() {}
33 33
34 // Parameters available at navigation start time ----------------------------- 34 // Parameters available at navigation start time -----------------------------
35 // 35 //
36 // These parameters are always available during the navigation. Note that 36 // These parameters are always available during the navigation. Note that
37 // some may change during navigation (e.g. due to server redirects). 37 // some may change during navigation (e.g. due to server redirects).
38 38
39 // The URL the frame is navigating to. This may change during the navigation 39 // The URL the frame is navigating to. This may change during the navigation
40 // when encountering a server redirect. 40 // when encountering a server redirect.
41 // This URL may not be the same as the virtual URL returned from
42 // WebContents::GetVisibleURL and WebContents::GetLastCommittedURL. For
43 // example, viewing a page's source navigates to the URL of the page, but the
44 // virtual URL is prefixed with "view-source:".
41 virtual const GURL& GetURL() = 0; 45 virtual const GURL& GetURL() = 0;
42 46
43 // Whether the navigation is taking place in the main frame or in a subframe. 47 // Whether the navigation is taking place in the main frame or in a subframe.
44 // This remains constant over the navigation lifetime. 48 // This remains constant over the navigation lifetime.
45 virtual bool IsInMainFrame() = 0; 49 virtual bool IsInMainFrame() = 0;
46 50
47 // Whether the navigation is taking place in a frame that is a direct child 51 // Whether the navigation is taking place in a frame that is a direct child
48 // of the main frame. This remains constant over the navigation lifetime. 52 // of the main frame. This remains constant over the navigation lifetime.
49 virtual bool IsParentMainFrame() = 0; 53 virtual bool IsParentMainFrame() = 0;
50 54
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 189
186 // The NavigationData that the embedder returned from 190 // The NavigationData that the embedder returned from
187 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will 191 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
188 // be a clone of the NavigationData. 192 // be a clone of the NavigationData.
189 virtual NavigationData* GetNavigationData() = 0; 193 virtual NavigationData* GetNavigationData() = 0;
190 }; 194 };
191 195
192 } // namespace content 196 } // namespace content
193 197
194 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 198 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW
« no previous file with comments | « no previous file | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698