Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207603003: Extract RequestInfo struct from ResourceLoaderBridge. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Avi (use Gerrit), darin (slow to review), jochen (gone - plz use gerrit), pilgrim_google, jamesr
Visibility:
Public.

Description

Extract RequestInfo struct from ResourceLoaderBridge. And move it into content/child/request_info.*. As requested by John in - https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode46 BUG=265753, 338338, 237249 TEST=content_unittests R=jam@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258845

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -108 lines) Patch
M chrome/renderer/security_filter_peer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/blink_platform_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread.h View 4 chunks +6 lines, -2 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
A content/child/request_info.h View 1 chunk +87 lines, -0 lines 0 comments Download
A content/child/request_info.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webkitplatformsupport_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/child/webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_destination_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/video_source_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/test_webkit_platform_support.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/resource_loader_bridge.h View 2 chunks +0 lines, -68 lines 0 comments Download
M webkit/child/resource_loader_bridge.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
tfarina
6 years, 9 months ago (2014-03-21 03:43:34 UTC) #1
jam
lgtm
6 years, 9 months ago (2014-03-21 15:48:08 UTC) #2
tfarina
TBRing Darin for webkit/ + chrome/ changes.
6 years, 9 months ago (2014-03-22 02:52:24 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-22 02:52:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/207603003/40001
6 years, 9 months ago (2014-03-22 02:53:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 02:55:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-22 02:55:34 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-22 03:03:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/207603003/40001
6 years, 9 months ago (2014-03-22 03:03:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 03:05:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-22 03:05:39 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-22 03:06:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/207603003/40001
6 years, 9 months ago (2014-03-22 03:06:31 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 04:15:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-22 04:15:41 UTC) #15
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-22 04:21:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/207603003/40001
6 years, 9 months ago (2014-03-22 04:21:35 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 02:34:49 UTC) #18
Message was sent while issue was closed. 
Change committed as 258845

Powered by Google App Engine
This is Rietveld 408576698