Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2075973002: Revert of Move content/browser/power_save_blocker to //device/power_save_blocker (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@power-save-next-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move content/browser/power_save_blocker to //device/power_save_blocker (patchset #19 id:400001 of https://codereview.chromium.org/1999953002/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/158097 but not CQ bots Original issue's description: > Move content/browser/power_save_blocker to //device/power_save_blocker > > This is mostly a mechanical move. The only "new" code is the new build > files, and the Android JNI registration that has its own version in > //device now instead of being part of the //content registration. > > R=jam@chromium.org > TBR=rockot,tedchoc > BUG=612337, 612563, 257943 > > Committed: https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4 > Cr-Commit-Position: refs/heads/master@{#400361} TBR=jam@chromium.org,hashimoto@chromium.org,tedchoc@chromium.org,sadrul@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612337, 612563, 257943 Committed: https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534 Cr-Commit-Position: refs/heads/master@{#400364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1472 lines, -1729 lines) Patch
M chrome/browser/media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/cast_transport_host_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M components/drive/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/drive/DEPS View 3 chunks +9 lines, -4 lines 0 comments Download
M components/drive/drive_uploader.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 6 chunks +21 lines, -23 lines 0 comments Download
M content/browser/download/download_request_core.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/download/download_request_core.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A content/browser/power_save_blocker_android.h View 1 chunk +11 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_android.cc View 1 chunk +105 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_chromeos.cc View 1 chunk +112 lines, -0 lines 0 comments Download
D content/browser/power_save_blocker_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
M content/browser/power_save_blocker_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A content/browser/power_save_blocker_impl.h View 1 chunk +74 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_impl.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_mac.cc View 1 chunk +120 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_ozone.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_win.cc View 1 chunk +160 lines, -0 lines 0 comments Download
A content/browser/power_save_blocker_x11.cc View 1 chunk +508 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 7 chunks +14 lines, -3 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java View 1 chunk +46 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A content/public/browser/power_save_blocker.h View 1 chunk +64 lines, -0 lines 0 comments Download
A content/public/browser/power_save_blocker_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
M device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D device/power_save_blocker/BUILD.gn View 1 chunk +0 lines, -89 lines 0 comments Download
D device/power_save_blocker/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D device/power_save_blocker/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D device/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java View 1 chunk +0 lines, -46 lines 0 comments Download
D device/power_save_blocker/power_save_blocker.h View 1 chunk +0 lines, -64 lines 0 comments Download
D device/power_save_blocker/power_save_blocker.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_android.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_chromeos.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_export.h View 1 chunk +0 lines, -28 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_impl.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_jni_registrar.h View 1 chunk +0 lines, -24 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_jni_registrar.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_mac.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_ozone.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_win.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_x11.cc View 1 chunk +0 lines, -506 lines 0 comments Download
M device/test/run_all_unittests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/power/power_api.h View 3 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 5 chunks +14 lines, -21 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
scottmg
Created Revert of Move content/browser/power_save_blocker to //device/power_save_blocker
4 years, 6 months ago (2016-06-17 05:18:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075973002/1
4 years, 6 months ago (2016-06-17 05:18:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 05:21:46 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 05:23:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534
Cr-Commit-Position: refs/heads/master@{#400364}

Powered by Google App Engine
This is Rietveld 408576698