Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: media/cast/video_sender/video_sender_unittest.cc

Issue 207593002: Cast: Enable use of VideoEncodeAccelerator for hardware video encoding (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/video_sender/video_sender_unittest.cc
diff --git a/media/cast/video_sender/video_sender_unittest.cc b/media/cast/video_sender/video_sender_unittest.cc
index 8847013fabe7a501a194305dce8d772fbd592d19..97823a838ad8a00a6ad1bebac0f70decb10b86e4 100644
--- a/media/cast/video_sender/video_sender_unittest.cc
+++ b/media/cast/video_sender/video_sender_unittest.cc
@@ -12,6 +12,8 @@
#include "media/cast/logging/simple_event_subscriber.h"
#include "media/cast/test/fake_gpu_video_accelerator_factories.h"
#include "media/cast/test/fake_single_thread_task_runner.h"
+#include "media/cast/test/fake_video_encode_accelerator.h"
+#include "media/cast/test/utility/default_config.h"
#include "media/cast/test/utility/video_utility.h"
#include "media/cast/transport/cast_transport_config.h"
#include "media/cast/transport/cast_transport_sender_impl.h"
@@ -32,6 +34,26 @@ static const int kHeight = 240;
using testing::_;
using testing::AtLeast;
+void CreateVideoEncodeAccelerator(
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
+ scoped_ptr<VideoEncodeAccelerator> fake_vea,
+ const base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
pwestin 2014/03/21 21:02:02 Use the proposed typedef
+ scoped_ptr<media::VideoEncodeAccelerator>)>&
+ callback) {
+ callback.Run(task_runner, fake_vea.Pass());
+}
+
+void CreateSharedMemory(
+ size_t size,
+ const base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
pwestin 2014/03/21 21:02:02 Use the proposed typedef
+ scoped_ptr<base::SharedMemory> shm(new base::SharedMemory());
+ if (!shm->CreateAndMapAnonymous(size)) {
+ NOTREACHED();
+ return;
+ }
+ callback.Run(shm.Pass());
+}
+
class TestPacketSender : public transport::PacketSender {
public:
TestPacketSender() : number_of_rtp_packets_(0), number_of_rtcp_packets_(0) {}
@@ -62,12 +84,14 @@ class PeerVideoSender : public VideoSender {
PeerVideoSender(
scoped_refptr<CastEnvironment> cast_environment,
const VideoSenderConfig& video_config,
- const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories,
+ const CreateVideoEncodeAcceleratorCallback& create_vea_cb,
+ const CreateVideoEncodeMemoryCallback& create_video_encode_mem_cb,
const CastInitializationCallback& cast_initialization_cb,
transport::CastTransportSender* const transport_sender)
: VideoSender(cast_environment,
video_config,
- gpu_factories,
+ create_vea_cb,
+ create_video_encode_mem_cb,
cast_initialization_cb,
transport_sender) {}
using VideoSender::OnReceivedCastFeedback;
@@ -137,18 +161,24 @@ class VideoSenderTest : public ::testing::Test {
video_config.codec = transport::kVp8;
if (external) {
- video_sender_.reset(new PeerVideoSender(
- cast_environment_,
- video_config,
- new test::FakeGpuVideoAcceleratorFactories(task_runner_),
- base::Bind(&VideoSenderTest::InitializationResult,
- base::Unretained(this)),
- transport_sender_.get()));
+ scoped_ptr<VideoEncodeAccelerator> fake_vea(
+ new test::FakeVideoEncodeAccelerator());
+ video_sender_.reset(
+ new PeerVideoSender(cast_environment_,
+ video_config,
+ base::Bind(&CreateVideoEncodeAccelerator,
+ task_runner_,
+ base::Passed(&fake_vea)),
+ base::Bind(&CreateSharedMemory),
+ base::Bind(&VideoSenderTest::InitializationResult,
+ base::Unretained(this)),
+ transport_sender_.get()));
} else {
video_sender_.reset(
new PeerVideoSender(cast_environment_,
video_config,
- NULL,
+ CreateDefaultVideoEncodeAcceleratorCallback(),
+ CreateDefaultVideoEncodeMemoryCallback(),
base::Bind(&VideoSenderTest::InitializationResult,
base::Unretained(this)),
transport_sender_.get()));

Powered by Google App Engine
This is Rietveld 408576698