Cast: Enable use of VideoEncodeAccelerator for hardware video encoding

Cast: Enable use of VideoEncodeAccelerator for hardware video encoding

Cast streaming library is currently using GpuVideoAcceleratorFactories
as the interface to access a VideoEncodeAccelerator. This interface
is not actually correct since Content API in Chrome doesn't provide
that. Moreover GpuVideoAcceleratorFactories also covers accelerated
video decoding which is not needed for a cast sender.

This code removes the use of GpuVideoAcceleratorFactories. It is
replaced by two callbacks. One for allocating a VideoEncodeAccelerator
and the second one allocates base::SharedMemory to store output data.

BUG=354267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258762

[Alpha Left Google, 2014-03-21 19:08:19]

Adding sheu and hshi. They can also review this change.

[pwestin, 2014-03-21 21:02:01]

2 more typedefs please

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h
File media/cast/cast_config.h (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h...
media/cast/cast_config.h:145: const
base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
const base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,          
                   scoped_ptr<media::VideoEncodeAccelerator>)>&)

is used in multiple places make is a typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h...
media/cast/cast_config.h:150: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>&)>
const base::Callback<void(scoped_ptr<base::SharedMemory>)>&)

is used in multiple places make is a typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
File media/cast/test/utility/default_config.cc (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/default_config.cc:12: void
CreateVideoEncodeAccelerator(const base::Callback<
Use the proposed typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/default_config.cc:20: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
Use the proposed typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
File media/cast/video_sender/external_video_encoder_unittest.cc (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/external_video_encoder_unittest.cc:29: const
base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
Use the proposed typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/external_video_encoder_unittest.cc:37: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
Use the proposed typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
File media/cast/video_sender/video_sender_unittest.cc (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/video_sender_unittest.cc:40: const
base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
Use the proposed typedef

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/video_sender_unittest.cc:48: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
Use the proposed typedef

[Alpha Left Google, 2014-03-21 21:37:12]

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h
File media/cast/cast_config.h (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h...
media/cast/cast_config.h:145: const
base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
On 2014/03/21 21:02:02, pwestin wrote:
> const base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,        
 
>                    scoped_ptr<media::VideoEncodeAccelerator>)>&)
> 
> is used in multiple places make is a typedef

Done.

https://codereview.chromium.org/207593002/diff/20001/media/cast/cast_config.h...
media/cast/cast_config.h:150: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>&)>
On 2014/03/21 21:02:02, pwestin wrote:
> const base::Callback<void(scoped_ptr<base::SharedMemory>)>&)
> 
> is used in multiple places make is a typedef

Done.

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
File media/cast/test/utility/default_config.cc (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/default_config.cc:12: void
CreateVideoEncodeAccelerator(const base::Callback<
On 2014/03/21 21:02:02, pwestin wrote:
> Use the proposed typedef

Done.

https://codereview.chromium.org/207593002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/default_config.cc:20: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
On 2014/03/21 21:02:02, pwestin wrote:
> Use the proposed typedef

Done.

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
File media/cast/video_sender/external_video_encoder_unittest.cc (right):

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/external_video_encoder_unittest.cc:29: const
base::Callback<void(scoped_refptr<base::SingleThreadTaskRunner>,
On 2014/03/21 21:02:02, pwestin wrote:
> Use the proposed typedef

Done.

https://codereview.chromium.org/207593002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/external_video_encoder_unittest.cc:37: const
base::Callback<void(scoped_ptr<base::SharedMemory>)>& callback) {
On 2014/03/21 21:02:02, pwestin wrote:
> Use the proposed typedef

Done.

[pwestin, 2014-03-21 21:42:45]

lgtm

[Alpha Left Google, 2014-03-21 21:47:26]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-03-21 21:48:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/207593002/30001

[commit-bot: I haz the power, 2014-03-22 03:20:33]

Change committed as 258762