mash: Convert FocusCycler to wm common types and move to //ash/common

ash/aura/wm_window_aura.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/aura/wm_window_aura.h"
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_root_window_controller_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/ash_constants.h"
@@ skipping 496 matching lines @@
 }
 
 void WmWindowAura::Hide() {
   window_->Hide();
 }
 
 void WmWindowAura::Show() {
   window_->Show();
 }
 
+views::Widget* WmWindowAura::GetWidget() {
+  return views::Widget::GetWidgetForNativeView(window_);
+}
+
 void WmWindowAura::CloseWidget() {

[msw, 2016/06/16 23:57:44]

nit: Remove this and inline GetWidget()->Close() for the one caller.

[James Cook, 2016/06/17 03:39:29]

I'm going to keep this, since there is a difference in CloseWidget() behavior
for WmWindowMus and I'm changing GetWidget() to GetInternalWidget().

-  DCHECK(views::Widget::GetWidgetForNativeView(window_));
-  views::Widget::GetWidgetForNativeView(window_)->Close();
+  DCHECK(GetWidget());
+  GetWidget()->Close();
 }
 
 bool WmWindowAura::IsFocused() const {
   return window_->HasFocus();
 }
 
 bool WmWindowAura::IsActive() const {
   return wm::IsActiveWindow(window_);
 }
 
@@ skipping 155 matching lines @@
                                               bool visible) {
   FOR_EACH_OBSERVER(WmWindowObserver, observers_,
                     OnWindowVisibilityChanging(this, visible));
 }
 
 void WmWindowAura::OnWindowTitleChanged(aura::Window* window) {
   FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowTitleChanged(this));
 }
 
 }  // namespace ash