Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2075913002: Revert of Support pixel antialising in DirectWrite. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, corey.lucier
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Support pixel antialising in DirectWrite. (patchset #4 id:60001 of https://codereview.chromium.org/2065833002/ ) Reason for revert: Moving to the new glyph run analysis changes things anyway, and the Chromium Win 10 bots are having issues with this. Revert until I have time to make the suppression wider. Original issue's description: > Support pixel antialising in DirectWrite. > > DirectWrite2 supports pixel antialiasing and rendering without hinting. > > BUG=skia:5416 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2065833002 > > TBR=reed > Will move SkTScopedComPtr into src. > > Committed: https://skia.googlesource.com/skia/+/bd770d619553a88eeaa64ff29082f62db5c9b4d2 TBR=reed@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5416 Committed: https://skia.googlesource.com/skia/+/73c7c3c2346033e0b5df123f1a6b488015443a55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -152 lines) Patch
M include/utils/win/SkTScopedComPtr.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkScalerContext_win_dw.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 12 chunks +34 lines, -115 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 3 chunks +0 lines, -21 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bungeman-skia
Created Revert of Support pixel antialising in DirectWrite.
4 years, 6 months ago (2016-06-16 21:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075913002/1
4 years, 6 months ago (2016-06-16 21:41:46 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 21:41:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73c7c3c2346033e0b5df123f1a6b488015443a55

Powered by Google App Engine
This is Rietveld 408576698