Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2075903002: Reorder DoFoo methods in QuicHttpStream's .cc file to match .h and remove two unused methods from t… (Closed)

Created:
4 years, 6 months ago by Ryan Hamilton
Modified:
4 years, 6 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder DoFoo methods in QuicHttpStream's .cc file to match .h and remove two unused methods from the .h Committed: https://crrev.com/67da818381199f49d9d7aef8a75a36af731715d9 Cr-Commit-Position: refs/heads/master@{#400334}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M net/quic/quic_http_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_http_stream.cc View 2 chunks +35 lines, -35 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Ryan Hamilton
4 years, 6 months ago (2016-06-16 21:25:58 UTC) #2
Jana
lgtm
4 years, 6 months ago (2016-06-16 22:45:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075903002/20001
4 years, 6 months ago (2016-06-16 22:46:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 03:00:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 03:01:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67da818381199f49d9d7aef8a75a36af731715d9
Cr-Commit-Position: refs/heads/master@{#400334}

Powered by Google App Engine
This is Rietveld 408576698