Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2075873003: Quickly fix the Compile Problem of Unused kkImageColorXformMetaData (Closed)

Created:
4 years, 6 months ago by liyuqian
Modified:
4 years, 6 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Quickly fix the Compile Problem of Unused kkImageColorXformMetaData TBR=msarett@google.com I don't know why the compiler is complaining that since ImageSlide.cpp is still using it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075873003 Committed: https://skia.googlesource.com/skia/+/ed330c8755044822ec536ce8eb0a98a8627302bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/viewer/Viewer.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075873003/1
4 years, 6 months ago (2016-06-17 00:54:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ed330c8755044822ec536ce8eb0a98a8627302bd
4 years, 6 months ago (2016-06-17 01:09:16 UTC) #5
msarett
4 years, 6 months ago (2016-06-17 12:36:02 UTC) #6
Message was sent while issue was closed.
LGTM

"I don't know why the compiler is complaining that since ImageSlide.cpp is still
using it"

Maybe ImageSlide.cpp isn't compiled on all of our bots?

Powered by Google App Engine
This is Rietveld 408576698