Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2075863003: Use runtime_deps to tell create_installer_archive what dlls to copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove other deps Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index a3dcae8d208547f31acbdf06f3d657c57dae44a0..38820d2ffbae26bfe0b8566aa54afe45528f0488 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -68,6 +68,25 @@ source_set("unit_tests") {
packed_files_rc_file = "$target_gen_dir/packed_files.rc"
+# The runtime deps are used to tell create_installer_archive what component
+# DLLs need to be packaged in a component build.
+setup_runtime_deps = "$root_gen_dir/setup.runtime_deps"
+chrome_runtime_deps = "$root_gen_dir/chrome_component.runtime_deps"
gab 2016/06/22 14:04:20 nit: flip order here so they are declared in same
+
+group("chrome_runtime_deps") {
+ write_runtime_deps = chrome_runtime_deps
+ data_deps = [
+ "//chrome",
+ ]
+}
+
+group("setup_runtime_deps") {
+ write_runtime_deps = setup_runtime_deps
+ data_deps = [
+ "//chrome/installer/setup",
+ ]
+}
+
action("archive") {
script = "//chrome/tools/build/win/create_installer_archive.py"
@@ -98,6 +117,10 @@ action("archive") {
rebase_path(packed_files_rc_file, root_build_dir),
"--target_arch=$current_cpu",
"--distribution=_google_chrome",
+ "--component_runtime_deps",
gab 2016/06/22 14:04:20 Actually since this param is passed even in non-co
+ rebase_path(chrome_runtime_deps, root_build_dir),
+ "--setup_runtime_deps",
+ rebase_path(setup_runtime_deps, root_build_dir),
# Optional arguments to generate diff installer.
#'--last_chrome_installer=C:/Temp/base',
@@ -109,6 +132,8 @@ action("archive") {
]
deps = [
+ ":chrome_runtime_deps",
+ ":setup_runtime_deps",
"//chrome",
"//chrome:main_dll",
"//chrome/browser/extensions/default_extensions",
« no previous file with comments | « no previous file | chrome/tools/build/win/create_installer_archive.py » ('j') | chrome/tools/build/win/create_installer_archive.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698