Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2075863003: Use runtime_deps to tell create_installer_archive what dlls to copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index 4eecab413281aa296d2a566541b7a4ac60a6aace..bd8204503888b675aab0281535814153fccaa60c 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -81,6 +81,10 @@ action("archive") {
release_file,
]
+ # The runtime deps are used to tell create_installer_archive what component
+ # build DLLs need to be packaged.
+ _installer_runtime_deps = "$root_gen_dir/mini_installer.runtime_deps"
+
outputs = [
# See also chrome.packed.7z conditionally added below.
"$root_out_dir/chrome.7z",
@@ -98,6 +102,8 @@ action("archive") {
rebase_path(packed_files_rc_file, root_build_dir),
"--target_arch=$current_cpu",
"--distribution=_google_chrome",
+ "--runtime_deps",
+ rebase_path(_installer_runtime_deps, root_build_dir),
# Optional arguments to generate diff installer.
#'--last_chrome_installer=C:/Temp/base',
@@ -151,6 +157,8 @@ action("archive") {
deps += [ "//v8" ]
}
+ write_runtime_deps = _installer_runtime_deps
+
depfile = "$target_gen_dir/archive.d"
args += [
"--depfile",
« no previous file with comments | « no previous file | chrome/tools/build/win/create_installer_archive.py » ('j') | chrome/tools/build/win/create_installer_archive.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698