Use runtime_deps to tell create_installer_archive what dlls to copy.

chrome/tools/build/win/create_installer_archive.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to create Chrome Installer archive.
 
   This script is used to create an archive of all the files required for a
   Chrome install in appropriate directory structure. It reads chrome.release
   file as input, creates chrome.7z archive, compresses setup.exe and
@@ skipping 445 matching lines @@
   # if is_debug is set to anything other than false, or if it
   # does not exist at all, we should use the default value (True).
   return 'Debug'
 
 
 # Copies component build DLLs and generates required config files and manifests
 # in order for chrome.exe and setup.exe to be able to find those DLLs at
 # run-time.
 # This is meant for developer builds only and should never be used to package
 # an official build.
-def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version):
+def DoComponentBuildTasks(staging_dir, build_dir, target_arch, runtime_deps,
+                          current_version):
   # Get the required directories for the upcoming operations.
   chrome_dir = os.path.join(staging_dir, CHROME_DIR)
   version_dir = os.path.join(chrome_dir, current_version)
   installer_dir = os.path.join(version_dir, 'Installer')
   # |installer_dir| is technically only created post-install, but we need it
   # now to add setup.exe's config and manifest to the archive.
   if not os.path.exists(installer_dir):
     os.mkdir(installer_dir)
 
   # Explicitly list the component DLLs setup.exe depends on (this list may
@@ skipping 10 matching lines @@
                                 'icuuc.dll',
                                 'msvc*.dll',
                                 'ucrtbase*.dll',
                                 'vcruntime*.dll',
                                 # DLLs needed due to source sets.
                                 'base_i18n.dll',
                                 'ipc.dll',
                                 'net.dll',
                                 'prefs.dll',
                                 'protobuf_lite.dll',
                                 'url_lib.dll' ]

[gab, 2016/06/17 18:27:11]

This write_runtime_deps thing is awesome :-). Can you please also replace the
list above with the runtime deps for setup.exe? Thanks!

   for setup_component_dll_glob in setup_component_dll_globs:
     setup_component_dlls = glob.glob(os.path.join(build_dir,
                                                   setup_component_dll_glob))
     if len(setup_component_dlls) == 0:
       raise Exception('Error: missing expected DLL for component build '
                       'mini_installer: "%s"' % setup_component_dll_glob)
     for setup_component_dll in setup_component_dlls:
       g_archive_inputs.append(setup_component_dll)
       shutil.copy(setup_component_dll, installer_dir)
 
   # Stage all the component DLLs found in |build_dir| to the |version_dir| (for
   # the version assembly to be able to refer to them below and make sure
   # chrome.exe can find them at runtime). The component DLLs are considered to
   # be all the DLLs which have not already been added to the |version_dir| by
   # virtue of chrome.release.

[gab, 2016/06/17 18:27:11]

Update comment:

# Stage all the DLLs listed in |runtime_deps| to the |version_dir| (for the
version assembly to be able to refer to them below and make sure chrome.exe can
find them at runtime), except the ones that are already staged (i.e.
non-component DLLs).

-  build_dlls = glob.glob(os.path.join(build_dir, '*.dll'))
+  if runtime_deps:
+    build_dlls = set()
+    args = open(runtime_deps).read()
+    for l in args.splitlines():
+      if os.path.splitext(l)[1] == ".dll":
+        build_dlls.add(os.path.join(build_dir, l))
+  else:
+    build_dlls = glob.glob(os.path.join(build_dir, '*.dll'))

[gab, 2016/06/17 18:27:11]

When would |runtime_deps| ever not be specified? Would rather not keep a code
path that isn't exercised.

[jbauman, 2016/06/17 19:51:24]

Do we currently want to continue supporting gyp with mini_installer?

   staged_dll_basenames = [os.path.basename(staged_dll) for staged_dll in \
                           glob.glob(os.path.join(version_dir, '*.dll'))]
   component_dll_filenames = []
   for component_dll in [dll for dll in build_dlls if \
                         os.path.basename(dll) not in staged_dll_basenames]:
     component_dll_name = os.path.basename(component_dll)
     # ash*.dll remoting_*.dll's don't belong in the archive (it doesn't depend
     # on them in gyp). Trying to copy them causes a build race when creating the
     # installer archive in component mode. See: crbug.com/180996 and
     # crbug.com/586967
     if (component_dll_name.startswith('remoting_') or
         component_dll_name.startswith('ash')):
       continue

[gab, 2016/06/17 18:27:11]

rm 528-534

 
     component_dll_filenames.append(component_dll_name)
     g_archive_inputs.append(component_dll)
     shutil.copy(component_dll, version_dir)
 
   # Augment {version}.manifest to include all component DLLs as part of the
   # assembly it constitutes, which will allow dependents of this assembly to
   # find these DLLs.
   version_assembly_dll_additions = []
   for dll_filename in component_dll_filenames:
@@ skipping 26 matching lines @@
                              staging_dir, options.output_dir,
                              options.enable_hidpi)
 
   # Now copy the remainder of the files from the build dir.
   CopyAllFilesToStagingDir(config, options.distribution,
                            staging_dir, options.build_dir,
                            options.enable_hidpi)
 
   if options.component_build == '1':
     DoComponentBuildTasks(staging_dir, options.build_dir,
-                          options.target_arch, current_version)
+                          options.target_arch, options.runtime_deps,
+                          current_version)
 
   version_numbers = current_version.split('.')
   current_build_number = version_numbers[2] + '.' + version_numbers[3]
   prev_build_number = ''
   if prev_version:
     version_numbers = prev_version.split('.')
     prev_build_number = version_numbers[2] + '.' + version_numbers[3]
 
   # Name of the archive file built (for example - chrome.7z or
   # patch-<old_version>-<new_version>.7z or patch-<new_version>.7z
@@ skipping 42 matching lines @@
       help='Name used to prefix names of generated archives.')
   parser.add_option('--enable_hidpi', default='0',
       help='Whether to include HiDPI resource files.')
   parser.add_option('--component_build', default='0',
       help='Whether this archive is packaging a component build. This will '
            'also turn off compression of chrome.7z into chrome.packed.7z and '
            'helpfully delete any old chrome.packed.7z in |output_dir|.')
   parser.add_option('--depfile',
       help='Generate a depfile with the given name listing the implicit inputs '
            'to the archive process that can be used with a build system.')
+  parser.add_option('--runtime_deps',
+      help='A file listing runtime dependencies. This will be used to get a '
+           'list of component build DLLs to archive.')

[gab, 2016/06/17 18:27:11]

Make this a required option given comment above.

   parser.add_option('--target_arch', default='x86',
       help='Specify the target architecture for installer - this is used '
            'to determine which CRT runtime files to pull and package '
            'with the installer archive {x86|x64}.')
   parser.add_option('-v', '--verbose', action='store_true', dest='verbose',
                     default=False)
 
   options, _ = parser.parse_args()
   if not options.build_dir:
     parser.error('You must provide a build dir.')
@@ skipping 14 matching lines @@
                                               MINI_INSTALLER_INPUT_FILE)
 
   return options
 
 
 if '__main__' == __name__:
   options = _ParseOptions()
   if options.verbose:
     print sys.argv
   sys.exit(main(options))