Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2075863002: Fix check for ARC_TO vs R_ARC_TO for vector assets (Closed)

Created:
4 years, 6 months ago by tdanderson
Modified:
4 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix check for ARC_TO vs R_ARC_TO for vector assets Vector assets using ARC_TO or R_ARC_TO are not drawn properly due to an incorrect command type check in paint_vector_icon.cc. To fix this, cache the command type at the top of the switch statement. BUG=620345 TEST=manual Committed: https://crrev.com/a2204bc3ed92d74ed6b18cc5bbc1cd5f33bbeefc Cr-Commit-Position: refs/heads/master@{#400272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/gfx/paint_vector_icon.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tdanderson
Evan, please take a look - seems we both missed this.
4 years, 6 months ago (2016-06-16 20:56:52 UTC) #2
Evan Stade
On 2016/06/16 20:56:52, tdanderson wrote: > Evan, please take a look - seems we both ...
4 years, 6 months ago (2016-06-16 21:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075863002/1
4 years, 6 months ago (2016-06-16 21:46:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 21:55:31 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 21:58:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2204bc3ed92d74ed6b18cc5bbc1cd5f33bbeefc
Cr-Commit-Position: refs/heads/master@{#400272}

Powered by Google App Engine
This is Rietveld 408576698