Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2075853002: remove colorprofiletype from imageinfo (Closed)

Created:
4 years, 6 months ago by reed1
Modified:
4 years, 6 months ago
Reviewers:
msarett, Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove colorprofiletype from imageinfo #

Patch Set 3 : remove colorprofiletype from imageinfo #

Total comments: 2

Patch Set 4 : continue writing an enum, with forward-mode for flattening the actual profile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -77 lines) Patch
M include/core/SkBitmap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkColorSpace.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkImageInfo.h View 1 6 chunks +65 lines, -50 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkImageInfo.cpp View 1 2 3 4 chunks +79 lines, -23 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
reed1
incomplete, but shows my proposed changes to the header
4 years, 6 months ago (2016-06-16 21:24:36 UTC) #3
reed1
If the header changes is mostly correct, we might land this even w/o having completely ...
4 years, 6 months ago (2016-06-16 21:25:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853002/20001
4 years, 6 months ago (2016-06-16 21:25:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 21:44:46 UTC) #8
reed1
ptal
4 years, 6 months ago (2016-06-17 12:15:44 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853002/40001
4 years, 6 months ago (2016-06-17 12:15:49 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 12:30:36 UTC) #13
msarett
LGTM https://codereview.chromium.org/2075853002/diff/40001/src/core/SkImageInfo.cpp File src/core/SkImageInfo.cpp (right): https://codereview.chromium.org/2075853002/diff/40001/src/core/SkImageInfo.cpp#newcode47 src/core/SkImageInfo.cpp:47: // fProfileType = (SkColorProfileType)((packed >> 16) & 0xFF); ...
4 years, 6 months ago (2016-06-17 12:44:19 UTC) #14
Brian Osman
lgtm
4 years, 6 months ago (2016-06-17 12:44:23 UTC) #15
reed1
https://codereview.chromium.org/2075853002/diff/40001/src/core/SkImageInfo.cpp File src/core/SkImageInfo.cpp (right): https://codereview.chromium.org/2075853002/diff/40001/src/core/SkImageInfo.cpp#newcode47 src/core/SkImageInfo.cpp:47: // fProfileType = (SkColorProfileType)((packed >> 16) & 0xFF); On ...
4 years, 6 months ago (2016-06-17 13:11:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853002/60001
4 years, 6 months ago (2016-06-17 16:14:21 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 16:26:46 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/960b2d69bbae19dc814f06d841b94ef71e291b48

Powered by Google App Engine
This is Rietveld 408576698