Improve logging of NSS errors that do not map to network errors.

net/socket/nss_ssl_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/nss_ssl_util.h"
 
 #include <nss.h>
 #include <secerr.h>
 #include <ssl.h>
 #include <sslerr.h>
@@ skipping 339 matching lines @@
     case SEC_ERROR_EXTRA_INPUT:
       return ERR_SSL_BAD_PEER_PUBLIC_KEY;
     // During renegotiation, the server presented a different certificate than
     // was used earlier.
     case SSL_ERROR_WRONG_CERTIFICATE:
       return ERR_SSL_SERVER_CERT_CHANGED;
     case SSL_ERROR_INAPPROPRIATE_FALLBACK_ALERT:
       return ERR_SSL_INAPPROPRIATE_FALLBACK;
 
     default: {
+      const char* pr_error = PR_ErrorToName(err);

[wtc, 2014/03/25 15:29:40]

This variable should be named "err_name" because it is the symbolic name of
|err|.

+      if (pr_error == NULL)
+        pr_error = "";
       if (IS_SSL_ERROR(err)) {
-        LOG(WARNING) << "Unknown SSL error " << err
+        LOG(WARNING) << "Unknown SSL error " << err << " (" << pr_error << ")"
                      << " mapped to net::ERR_SSL_PROTOCOL_ERROR";
         return ERR_SSL_PROTOCOL_ERROR;
       }
-      LOG(WARNING) << "Unknown error " << err << " mapped to net::ERR_FAILED";
+      LOG(WARNING) << "Unknown error " << err << " (" << pr_error << ")"
+                   << " mapped to net::ERR_FAILED";
       return ERR_FAILED;
     }
   }
 }
 
 // Returns parameters to attach to the NetLog when we receive an error in
 // response to a call to an NSS function.  Used instead of
 // NetLogSSLErrorCallback with events of type TYPE_SSL_NSS_ERROR.
 base::Value* NetLogSSLFailedNSSFunctionCallback(
     const char* function,
@@ skipping 13 matching lines @@
                           const char* param) {
   DCHECK(function);
   DCHECK(param);
   net_log.AddEvent(
       NetLog::TYPE_SSL_NSS_ERROR,
       base::Bind(&NetLogSSLFailedNSSFunctionCallback,
                  function, param, PR_GetError()));
 }
 
 }  // namespace net