Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2075813002: Remove ash_shell audio system tray item on Windows. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, Ben Goodger (Google), James Cook
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ash_shell audio system tray item on Windows. This is not used for production; likely not needed for dev/test. BUG=619636 TEST=Audio item no longer present in ash_shell_with_content on Windows. R=sky@chromium.org Committed: https://crrev.com/f0b5fc8ab5e8a061e22fdc9d2c173a78333af468 Cr-Commit-Position: refs/heads/master@{#400288}

Patch Set 1 #

Patch Set 2 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -225 lines) Patch
M ash/ash.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
D ash/system/win/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/system/win/audio/tray_audio_delegate_win.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ash/system/win/audio/tray_audio_delegate_win.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D ash/system/win/audio/tray_audio_win.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/system/win/audio/tray_audio_win.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 6 months ago (2016-06-16 20:32:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075813002/1
4 years, 6 months ago (2016-06-16 20:37:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/22208) ios-device-gn on ...
4 years, 6 months ago (2016-06-16 20:39:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075813002/20001
4 years, 6 months ago (2016-06-16 21:55:38 UTC) #8
sky
LGTM
4 years, 6 months ago (2016-06-16 22:09:40 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 23:04:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075813002/20001
4 years, 6 months ago (2016-06-16 23:08:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 23:16:26 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 23:21:17 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0b5fc8ab5e8a061e22fdc9d2c173a78333af468
Cr-Commit-Position: refs/heads/master@{#400288}

Powered by Google App Engine
This is Rietveld 408576698