Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2075803002: [Rietveld] Allow whitelisted email accounts to access Rietveld. (Closed)

Created:
4 years, 6 months ago by stgao
Modified:
4 years, 6 months ago
Reviewers:
jrobbins, Bons
CC:
jrobbins, chanli, chromium-reviews, lijeffrey
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Rietveld] Allow whitelisted email accounts to access Rietveld. BUG=620838 Committed: https://chromium.googlesource.com/infra/infra/+/2abcc9ebc3d6fde30dc414a418251ebe714a87d1

Patch Set 1 #

Patch Set 2 : Support emails in all domains instead of just App Engine service accounts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -25 lines) Patch
M appengine/chromium_rietveld/codereview/auth_utils.py View 1 4 chunks +55 lines, -20 lines 0 comments Download
M appengine/chromium_rietveld/codereview/views.py View 1 3 chunks +11 lines, -4 lines 0 comments Download
M appengine/chromium_rietveld/tests/test_auth_utils.py View 1 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
stgao
4 years, 6 months ago (2016-06-16 19:57:09 UTC) #2
Bons
lgtm but please wait until jrobbins approves before submitting to the CQ
4 years, 6 months ago (2016-06-16 21:30:37 UTC) #4
jrobbins
lgtm Thanks for aligning this with the internal version as much as posible.
4 years, 6 months ago (2016-06-16 23:17:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075803002/20001
4 years, 6 months ago (2016-06-16 23:22:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 23:36:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/2abcc9ebc3d6fde30dc414a418251...

Powered by Google App Engine
This is Rietveld 408576698