src/runtime.cc - Issue 20758002: Compilation type and state allocate an unnecessary Smi on v8::Script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 20758002: Compilation type and state allocate an unnecessary Smi on v8::Script. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@master

Patch Set: feedback. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 29b43ff99fc929d4a0c1ca8bbb13470b467d2a82..afa728ded18d2e02a29d5102ef1202b521d9db62 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -12887,7 +12887,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_DebugSetScriptSource) {

RUNTIME_ASSERT(script_wrapper->value()->IsScript());

Handle<Script> script(Script::cast(script_wrapper->value()));

- int compilation_state = Smi::cast(script->compilation_state())->value();

+ int compilation_state = script->compilation_state();

RUNTIME_ASSERT(compilation_state == Script::COMPILATION_STATE_INITIAL);

script->set_source(*source);

« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »