src/isolate.cc - Issue 20758002: Compilation type and state allocate an unnecessary Smi on v8::Script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 20758002: Compilation type and state allocate an unnecessary Smi on v8::Script. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@master

Patch Set: feedback. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index ccd6f280dc0ae0415e0598555b8fddc5f2bb6ad8..89bd399bd0681a20444dc93272c8bd71ef16bfbd 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -816,9 +816,9 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace(

}

if (options & StackTrace::kIsEval) {

- int type = Smi::cast(script->compilation_type())->value();

- Handle<Object> is_eval = (type == Script::COMPILATION_TYPE_EVAL) ?

- factory()->true_value() : factory()->false_value();

+ Handle<Object> is_eval =

+ script->compilation_type() == Script::COMPILATION_TYPE_EVAL ?

+ factory()->true_value() : factory()->false_value();

CHECK_NOT_EMPTY_HANDLE(this,

JSObject::SetLocalPropertyIgnoreAttributes(

stack_frame, eval_key, is_eval, NONE));

« no previous file with comments | « src/factory.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »