Compilation type and state allocate an unnecessary Smi on v8::Script.

src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 3189d840304c7cbb5be807cc9b47c8ef470a9372..f549e41cb5fac541cf15daaf6c5eb35e55bcb782 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -4482,12 +4482,28 @@ ACCESSORS(Script, data, Object, kDataOffset)
 ACCESSORS(Script, context_data, Object, kContextOffset)
 ACCESSORS(Script, wrapper, Foreign, kWrapperOffset)
 ACCESSORS_TO_SMI(Script, type, kTypeOffset)
-ACCESSORS_TO_SMI(Script, compilation_type, kCompilationTypeOffset)
-ACCESSORS_TO_SMI(Script, compilation_state, kCompilationStateOffset)
 ACCESSORS(Script, line_ends, Object, kLineEndsOffset)
 ACCESSORS(Script, eval_from_shared, Object, kEvalFromSharedOffset)
 ACCESSORS_TO_SMI(Script, eval_from_instructions_offset,
                  kEvalFrominstructionsOffsetOffset)
+ACCESSORS_TO_SMI(Script, flags, kFlagsOffset);
+  Script::CompilationType Script::compilation_type() {

[Michael Starzinger, 2013/07/29 14:43:58]

nit: Indentation is off, this should be at the top-level. Also can we add an
empty newline between the "flags" accessor and the other accessors for
readability?

[Mike West, 2013/07/29 14:52:12]

Sure.

+    return BooleanBit::get(flags(), kCompilationTypeBit) ?
+        COMPILATION_TYPE_EVAL : COMPILATION_TYPE_HOST;
+  }
+  void Script::set_compilation_type(CompilationType type) {
+    set_flags(BooleanBit::set(flags(), kCompilationTypeBit,
+        type == COMPILATION_TYPE_EVAL));
+  }
+  Script::CompilationState Script::compilation_state() {
+    return BooleanBit::get(flags(), kCompilationStateBit) ?
+        COMPILATION_STATE_COMPILED : COMPILATION_STATE_INITIAL;
+  }
+  void Script::set_compilation_state(CompilationState state) {
+    set_flags(BooleanBit::set(flags(), kCompilationStateBit,
+        state == COMPILATION_STATE_COMPILED));
+  }
+
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
 ACCESSORS(DebugInfo, shared, SharedFunctionInfo, kSharedFunctionInfoIndex)