Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/liveedit.cc

Issue 20758002: Compilation type and state allocate an unnecessary Smi on v8::Script. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@master
Patch Set: feedback. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1540 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 1551
1552 Handle<String> original_source(String::cast(original->source())); 1552 Handle<String> original_source(String::cast(original->source()));
1553 Handle<Script> copy = isolate->factory()->NewScript(original_source); 1553 Handle<Script> copy = isolate->factory()->NewScript(original_source);
1554 1554
1555 copy->set_name(original->name()); 1555 copy->set_name(original->name());
1556 copy->set_line_offset(original->line_offset()); 1556 copy->set_line_offset(original->line_offset());
1557 copy->set_column_offset(original->column_offset()); 1557 copy->set_column_offset(original->column_offset());
1558 copy->set_data(original->data()); 1558 copy->set_data(original->data());
1559 copy->set_type(original->type()); 1559 copy->set_type(original->type());
1560 copy->set_context_data(original->context_data()); 1560 copy->set_context_data(original->context_data());
1561 copy->set_compilation_type(original->compilation_type());
1562 copy->set_eval_from_shared(original->eval_from_shared()); 1561 copy->set_eval_from_shared(original->eval_from_shared());
1563 copy->set_eval_from_instructions_offset( 1562 copy->set_eval_from_instructions_offset(
1564 original->eval_from_instructions_offset()); 1563 original->eval_from_instructions_offset());
1565 1564
1565 // Copy all the flags, but clear compilation state.
1566 copy->set_flags(original->flags());
1567 copy->set_compilation_state(Script::COMPILATION_STATE_INITIAL);
1568
1566 return copy; 1569 return copy;
1567 } 1570 }
1568 1571
1569 1572
1570 Object* LiveEdit::ChangeScriptSource(Handle<Script> original_script, 1573 Object* LiveEdit::ChangeScriptSource(Handle<Script> original_script,
1571 Handle<String> new_source, 1574 Handle<String> new_source,
1572 Handle<Object> old_script_name) { 1575 Handle<Object> old_script_name) {
1573 Isolate* isolate = original_script->GetIsolate(); 1576 Isolate* isolate = original_script->GetIsolate();
1574 Handle<Object> old_script_object; 1577 Handle<Object> old_script_object;
1575 if (old_script_name->IsString()) { 1578 if (old_script_name->IsString()) {
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
2125 2128
2126 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2129 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2127 return false; 2130 return false;
2128 } 2131 }
2129 2132
2130 #endif // ENABLE_DEBUGGER_SUPPORT 2133 #endif // ENABLE_DEBUGGER_SUPPORT
2131 2134
2132 2135
2133 2136
2134 } } // namespace v8::internal 2137 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698