Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by sangwoo Modified:
4 years, 6 months ago Reviewers:
nodir CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert table to list in |useful_urls.md|
Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax.
It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table",
convert table to list.
BUG=524256
Committed: https://crrev.com/82d873a0a0947bb6a37685ddda322a325c0db330
Cr-Commit-Position: refs/heads/master@{#400583}
Patch Set 1 #
Created: 4 years, 6 months ago
Messages
Total messages: 14 (7 generated)
Description was changed from ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 ========== to ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 ==========
sangwoo108@gmail.com changed reviewers: + nodir@chromium.org
lgtm
The CQ bit was checked by sangwoo108@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075793004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sangwoo108@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075793004/1
Message was sent while issue was closed.
Description was changed from ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 ========== to ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 ========== to ========== Convert table to list in |useful_urls.md| Current |useful_urls.md| is not rendered in viewer properly because of wrong syntax. It needs header before it's rows. But since Google mardkdown style guide says "Prefer list to table", convert table to list. BUG=524256 Committed: https://crrev.com/82d873a0a0947bb6a37685ddda322a325c0db330 Cr-Commit-Position: refs/heads/master@{#400583} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/82d873a0a0947bb6a37685ddda322a325c0db330 Cr-Commit-Position: refs/heads/master@{#400583} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
