[Telemetry] Make discover throw exceptions when it detects duplicate keys indexed by class name

[Telemetry] Make discover throw exceptions when it detects duplicate keys indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend (https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05ac80ba6ae7cc3a/telemetry/telemetry/internal/platform/posix_platform_backend_unittest.py#L13)


Change announcement: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6FlJJDFWQA)

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/897866760cc7c37b766620f2589ad19026e775b1

[nednguyen, 2016-06-27 04:50:12]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys

BUG=catapult:#
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

BUG=catapult:#
==========

[nednguyen, 2016-06-27 04:50:28]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

BUG=catapult:#
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name
==========

[nednguyen, 2016-06-27 04:51:42]

nednguyen@google.com changed reviewers:
+ kouhei@chromium.org

[nednguyen, 2016-06-27 04:51:58]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 04:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-06-27 04:52:59]

On 2016/06/27 04:52:01, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Note to myself: this can be a breaking change, hence I should send out a notice
to telemetry-announce@

[kouhei (in TOK), 2016-06-27 04:53:41]

lgtm

telemetry/telemetry/internal/platform/linux_based_platform_backend_unittest.py:
Would you describe the change here?

[nednguyen, 2016-06-27 04:54:15]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)
==========

[nednguyen, 2016-06-27 04:56:06]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with 
posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)
==========

[nednguyen, 2016-06-27 04:56:22]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with 
posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)
==========

[nednguyen, 2016-06-27 04:56:32]

On 2016/06/27 04:53:41, kouhei wrote:
> lgtm
> 
>
telemetry/telemetry/internal/platform/linux_based_platform_backend_unittest.py:
> Would you describe the change here?

Done

[commit-bot: I haz the power, 2016-06-27 05:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 05:13:31]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-06-30 17:57:40]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)


COMMIT=false (Only commit this after July 7th, see:
https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6F...)
==========

[nednguyen, 2016-07-08 04:09:57]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)


COMMIT=false (Only commit this after July 7th, see:
https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6F...)
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)


Change announcement:
https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6F...)
==========

[nednguyen, 2016-07-08 04:10:00]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-07-08 04:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 04:36:17]

Description was changed from

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)


Change announcement:
https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6F...)
==========

to

==========
[Telemetry] Make discover throw exceptions when it detects duplicate keys
indexed by class name

We don't  throw exceptions when there is duplicate keys indexed by 
module name because telemetry_perf_unittest currently depends on this
naming collision to reduce the number of benchmark it smokes test (bad!)

This CL also renames linux_based_platform_backend_unittest.TestBackend classes
to 
linux_based_platform_backend_unittest.TestLinuxBackend to
avoid naming collision with posix_platform_backend_unittest.TestBackend
(https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05a...)


Change announcement:
https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6F...)

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-08 04:36:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[commit-bot: I haz the power, 2016-07-08 04:36:20]

CQ bit was unchecked.

[Ken Russell (switch to Gerrit), 2016-07-09 00:58:32]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-07-09 00:58:33]

This breaks all of the GPU tests on the Chromium waterfall. See the failing
tryjobs like:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

from this failed roll:
https://codereview.chromium.org/2136653002

[Ken Russell (switch to Gerrit), 2016-07-09 00:59:25]

+more Telemetry people because this should probably be reverted (and I don't
have privileges to do so)

[nednguyen, 2016-07-09 01:22:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2137783002/ by nednguyen@google.com.

The reason for reverting is: Breaks all of the GPU tests on the Chromium
waterfall: https://codereview.chromium.org/2136653002
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel....

[nednguyen, 2016-07-09 10:31:42]

On 2016/07/09 01:22:09, nednguyen (ooo til 7-11) wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2137783002/ by mailto:nednguyen@google.com.
> 
> The reason for reverting is: Breaks all of the GPU tests on the Chromium
> waterfall: https://codereview.chromium.org/2136653002
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel....

The breakage could be a real bug in gpu tests:

AssertionError: Found conflicting classes for the same key: key=test_base,
class_1=<class 'gpu_tests.cloud_storage_test_base.TestBase'>, class_2=<class
'gpu_tests.gpu_test_base.TestBase'>

It's possible that currently, one of the two classes is skipped. I will make a
CL to rename cloud_storage_test_base.TestBase to
cloud_storage_test_base.CloudStorageTestBase