Issue 207573002: Remove FontDescription::mutableFontDescription

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207573002: Remove FontDescription::mutableFontDescription (Closed)

Created:
6 years, 9 months ago by eae

Modified:
6 years, 9 months ago

Reviewers:
dglazkov

CC:
blink-reviews, jamesr, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jbroman, danakj, Rik, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove FontDescription::mutableFontDescription Change RenderStyle::setWordSpacing and RenderStyle::setLetterSpacing to replace the FontDescription instead of modifying the existing instance, the same way the other font methods already do. This allows us to remove the mutableFontDescription method from FontDescription. R=dglazkov@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169718

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	Source/core/rendering/style/RenderStyle.cpp	View		1 chunk	+17 lines, -2 lines	0 comments	Download
	M	Source/platform/fonts/Font.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/207573002/1

6 years, 9 months ago (2014-03-21 02:43:10 UTC) #3

Message was sent while issue was closed.

Change committed as 169718

Expand Messages | Collapse Messages