Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2075663002: Remove hook for setting a provider for an EmbedderUriResolver (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove hook for setting a provider for an EmbedderUriResolver R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/34a71429d905abfbc444dbbe3a25e559a10ab64c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -92 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +3 lines, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 4 chunks +1 line, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/plugin/embedded_resolver_provider.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 4 chunks +3 lines, -19 lines 0 comments Download
M pkg/analyzer_cli/lib/starter.dart View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 6 months ago (2016-06-16 15:56:51 UTC) #2
pquitslund
lgtm
4 years, 6 months ago (2016-06-16 17:16:09 UTC) #3
Brian Wilkerson
4 years, 6 months ago (2016-06-16 17:28:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34a71429d905abfbc444dbbe3a25e559a10ab64c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698