sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart - Issue 207563002: Move pub's web socket API over to use JSON RPC 2.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart

Issue 207563002: Move pub's web socket API over to use JSON RPC 2.0. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_responds_with_id_test.dart ('k') | sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_arg_errors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart

diff --git a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart b/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart

index 876142f0de4a0e3407241ce2ca28e6534fad2709..a3de26affa8fb1b21fe32cf613b26e547aad7f27 100644

--- a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart

+++ b/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart

@@ -26,11 +26,9 @@ main() {

pubServe(args: ["web"]);

// Bind the new directory.

- expectWebSocketCall({

- "command": "serveDirectory",

- "path": "test"

- }, replyMatches: {"url": matches(r"http://127\.0\.0\.1:\d+")})

- .then((response) {

+ expectWebSocketResult("serveDirectory", {"path": "test"}, {

+ "url": matches(r"http://127\.0\.0\.1:\d+")

+ }).then((response) {

var url = Uri.parse(response["url"]);

registerServerPort("test", url.port);

});