sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart - Issue 207563002: Move pub's web socket API over to use JSON RPC 2.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart

Issue 207563002: Move pub's web socket API over to use JSON RPC 2.0. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/barback_server.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart b/sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart

similarity index 98%

copy from sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart

copy to sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart

index eeb804f98f6947641fb86e6c20dbf9f36db893b3..3ffa32562c774e8175c5a2c035ac0f39c9ba0d65 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart

@@ -2,7 +2,9 @@

// BSD-style license that can be found in the LICENSE file.

-library pub.barback.web_socket_api;

+// TODO(nweiz): Remove this when the Editor is using the admin server port. See

+// issue 17640.

+library pub.barback.old_web_socket_api;

import 'dart:async';

import 'dart:convert';

@@ -53,7 +55,7 @@ import '../log.dart' as log;

/// category of error.

///

/// No successful response map will contain a key named "error".

-class WebSocketApi {

+class OldWebSocketApi {

final WebSocket _socket;

final BuildEnvironment _environment;