Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

Issue 207563002: Move pub's web socket API over to use JSON RPC 2.0. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart b/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart
index d0ffd784a980de5926916fba07dba59f962a9c56..f9fb34c3288cc4257eec325e5e839f4f4c386b00 100644
--- a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart
+++ b/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart
@@ -4,6 +4,7 @@
library pub_tests;
+import 'package:json_rpc_2/error_code.dart' as rpc_error_code;
import 'package:scheduled_test/scheduled_test.dart';
import '../../descriptor.dart' as d;
@@ -22,52 +23,29 @@ main() {
]).create();
});
- integration("responds with an error if 'path' is missing", () {
- pubServe();
- expectWebSocketCall({
- "command": "serveDirectory"
- }, replyEquals: {
- "code": "BAD_ARGUMENT",
- "error": 'Missing "path" argument.'
- });
- endPubServe();
- });
-
integration("responds with an error if 'path' is not a string", () {
pubServe();
- expectWebSocketCall({
- "command": "serveDirectory",
- "path": 123
- }, replyEquals: {
- "code": "BAD_ARGUMENT",
- "error": '"path" must be a string. Got 123.'
- });
+ expectWebSocketCall("serveDirectory", {"path": 123},
+ errorCode: rpc_error_code.INVALID_PARAMS,
+ errorMessage: 'Parameter "path" for method "serveDirectory" must be a '
+ 'string, but was 123.');
endPubServe();
});
integration("responds with an error if 'path' is absolute", () {
pubServe();
- expectWebSocketCall({
- "command": "serveDirectory",
- "path": "/absolute.txt"
- }, replyEquals: {
- "code": "BAD_ARGUMENT",
- "error": '"path" must be a relative path. Got "/absolute.txt".'
- });
+ expectWebSocketCall("serveDirectory", {"path": "/absolute.txt"},
+ errorCode: rpc_error_code.INVALID_PARAMS,
+ errorMessage: '"path" must be a relative path. Got "/absolute.txt".');
endPubServe();
});
integration("responds with an error if 'path' reaches out", () {
pubServe();
- expectWebSocketCall({
- "command": "serveDirectory",
- "path": "a/../../bad.txt"
- }, replyEquals: {
- "code": "BAD_ARGUMENT",
- "error":
- '"path" cannot reach out of its containing directory. '
- 'Got "a/../../bad.txt".'
- });
+ expectWebSocketCall("serveDirectory", {"path": "a/../../bad.txt"},
+ errorCode: rpc_error_code.INVALID_PARAMS,
+ errorMessage: '"path" cannot reach out of its containing directory. '
+ 'Got "a/../../bad.txt".');
endPubServe();
});
}

Powered by Google App Engine
This is Rietveld 408576698