Refactor git_common config and die

Refactor git_common config and die

R=iannucci@chromium.org
BUG=376099
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aa2ddd81d57f5025c490658ebe829b6a5c803e0

[agable, 2016-06-21 14:10:57]

agable@chromium.org changed reviewers:
+ tandrii@chromium.org

[agable, 2016-06-21 14:10:58]

+tandrii since iannucci@ is on vacation

[tandrii(chromium), 2016-06-21 14:22:49]

I like your description :) LGTM % optional comment

https://codereview.chromium.org/2075603002/diff/1/git_common.py
File git_common.py (right):

https://codereview.chromium.org/2075603002/diff/1/git_common.py#newcode325
git_common.py:325: Your git repo has too many branches (%d/%d) for this tool to
work well.
how about adding a plug for git cl archive. Say, 

Tip: have you considered running "git cl archive"?

[agable, 2016-06-21 14:31:39]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-21 14:31:40]

https://codereview.chromium.org/2075603002/diff/1/git_common.py
File git_common.py (right):

https://codereview.chromium.org/2075603002/diff/1/git_common.py#newcode325
git_common.py:325: Your git repo has too many branches (%d/%d) for this tool to
work well.
On 2016/06/21 at 14:22:49, tandrii(chromium) wrote:
> how about adding a plug for git cl archive. Say, 
> 
> Tip: have you considered running "git cl archive"?

Good idea, done.

[agable, 2016-06-21 14:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2075603002/#ps20001
(title: "Add message about git cl archive")

[commit-bot: I haz the power, 2016-06-21 14:31:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075603002/20001

[commit-bot: I haz the power, 2016-06-21 14:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 14:39:02]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[agable, 2016-06-21 14:43:30]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-21 14:43:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2075603002/#ps40001
(title: "Fix unintended change")

[commit-bot: I haz the power, 2016-06-21 14:43:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075603002/40001

[commit-bot: I haz the power, 2016-06-21 14:47:05]

Description was changed from

==========
Refactor git_common config and die

R=iannucci@chromium.org
BUG=376099
==========

to

==========
Refactor git_common config and die

R=iannucci@chromium.org
BUG=376099

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aa2ddd81d57f5...
==========

[commit-bot: I haz the power, 2016-06-21 14:47:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aa2ddd81d57f5...