[Android, Media] Don't unlock MediaStream elements; instead allow MS to autoplay without a gesture.

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 423 matching lines @@
     , m_seeking(false)
     , m_sentStalledEvent(false)
     , m_ignorePreloadNone(false)
     , m_textTracksVisible(false)
     , m_shouldPerformAutomaticTrackSelection(true)
     , m_tracksAreReady(true)
     , m_processingPreferenceChange(false)
     , m_remoteRoutesAvailable(false)
     , m_playingRemotely(false)
     , m_inOverlayFullscreenVideo(false)
+    , m_unlockedUserGestureForMediaStream(false)
     , m_audioTracks(AudioTrackList::create(*this))
     , m_videoTracks(VideoTrackList::create(*this))
     , m_textTracks(nullptr)
     , m_playPromiseResolveTask(CancellableTaskFactory::create(this, &HTMLMediaElement::resolveScheduledPlayPromises))
     , m_playPromiseRejectTask(CancellableTaskFactory::create(this, &HTMLMediaElement::rejectScheduledPlayPromises))
     , m_audioSourceNode(nullptr)
     , m_autoplayHelperClient(AutoplayHelperClientImpl::create(this))
     , m_autoplayHelper(AutoplayExperimentHelper::create(m_autoplayHelperClient.get()))
     , m_remotePlaybackClient(nullptr)
 {
     ThreadState::current()->registerPreFinalizer(this);
 
     DVLOG(MEDIA_LOG_LEVEL) << "HTMLMediaElement(" << (void*)this << ")";
 
-    // If any experiment is enabled, then we want to enable a user gesture by
-    // default, otherwise the experiment does nothing.
-    if ((document.settings() && document.settings()->mediaPlaybackRequiresUserGesture())
-        || m_autoplayHelper->isExperimentEnabled()) {
-        m_lockedPendingUserGesture = true;
-    }
+    m_lockedPendingUserGesture = needToLockPendingUserGesture(document);
 
     setHasCustomStyleCallbacks();
     addElementToDocumentMap(this, &document);
 
     UseCounter::count(document, UseCounter::HTMLMediaElement);
 }
 
 HTMLMediaElement::~HTMLMediaElement()
 {
     DVLOG(MEDIA_LOG_LEVEL) << "~HTMLMediaElement(" << (void*)this << ")";
@@ skipping 18 matching lines @@
     // Also see http://crbug.com/275223 for more details.
     clearMediaPlayerAndAudioSourceProviderClientWithoutLocking();
 }
 
 void HTMLMediaElement::didMoveToNewDocument(Document& oldDocument)
 {
     DVLOG(MEDIA_LOG_LEVEL) << "didMoveToNewDocument(" << (void*)this << ")";
 
     // If any experiment is enabled, then we want to enable a user gesture by
     // default, otherwise the experiment does nothing.
-    bool oldDocumentRequiresUserGesture = (oldDocument.settings() && oldDocument.settings()->mediaPlaybackRequiresUserGesture())
-        || m_autoplayHelper->isExperimentEnabled();
-    bool newDocumentRequiresUserGesture = (document().settings() && document().settings()->mediaPlaybackRequiresUserGesture())
-        || m_autoplayHelper->isExperimentEnabled();
+    bool oldDocumentRequiresUserGesture = needToLockPendingUserGesture(oldDocument);
+    bool newDocumentRequiresUserGesture = needToLockPendingUserGesture(document());
     if (newDocumentRequiresUserGesture && !oldDocumentRequiresUserGesture) {
         m_lockedPendingUserGesture = true;
     }
 
     if (m_shouldDelayLoadEvent) {
         document().incrementLoadEventDelayCount();
         // Note: Keeping the load event delay count increment on oldDocument that was added
         // when m_shouldDelayLoadEvent was set so that destruction of m_webMediaPlayer can not
         // cause load event dispatching in oldDocument.
     } else {
@@ skipping 173 matching lines @@
 }
 
 void HTMLMediaElement::setSrc(const AtomicString& url)
 {
     setAttribute(srcAttr, url);
 }
 
 void HTMLMediaElement::setSrcObject(MediaStreamDescriptor* srcObject)
 {
     DVLOG(MEDIA_LOG_LEVEL) << "setSrcObject(" << (void*)this << ")";
+
     m_srcObject = srcObject;
+
+    if (m_unlockedUserGestureForMediaStream)
+        lockUserGesture();
+
     invokeLoadAlgorithm();
 }
 
 HTMLMediaElement::NetworkState HTMLMediaElement::getNetworkState() const
 {
     return m_networkState;
 }
 
 String HTMLMediaElement::canPlayType(const String& mimeType) const
 {
@@ skipping 294 matching lines @@
 
     // The resource fetch algorithm
     setNetworkState(NETWORK_LOADING);
 
     m_autoplayHelper->loadingStarted();
 
     // Set m_currentSrc *before* changing to the cache url, the fact that we are loading from the app
     // cache is an internal detail not exposed through the media element API.
     m_currentSrc = url;
 
+    if (m_unlockedUserGestureForMediaStream)
+        lockUserGesture();
+
     if (m_audioSourceNode)
         m_audioSourceNode->onCurrentSrcChanged(m_currentSrc);
 
     DVLOG(MEDIA_LOG_LEVEL) << "loadResource(" << (void*)this << ") - m_currentSrc -> " << urlForLoggingMedia(m_currentSrc);
 
     startProgressEventTimer();
 
     // Reset display mode to force a recalculation of what to show because we are resetting the player.
     setDisplayMode(Unknown);
 
     setPlayerPreload();
 
     if (fastHasAttribute(mutedAttr))
         m_muted = true;
     updateVolume();
 
     DCHECK(!m_mediaSource);
 
     bool attemptLoad = true;
 
     bool isStreamOrBlobUrl = source.isMediaStream() || url.protocolIs(mediaSourceBlobProtocol);
     if (isStreamOrBlobUrl) {
         bool isMediaStream = source.isMediaStream() || (source.isURL() && isMediaStreamURL(url.getString()));
         if (isMediaStream) {
             m_autoplayHelper->unlockUserGesture(GesturelessPlaybackEnabledByStream);
+            m_unlockedUserGestureForMediaStream = true;
         } else {
             m_mediaSource = HTMLMediaSource::lookup(url.getString());
 
             if (m_mediaSource) {
                 if (!m_mediaSource->attachToElement(this)) {
                     // Forget our reference to the MediaSource, so we leave it alone
                     // while processing remainder of load failure.
                     m_mediaSource = nullptr;
                     attemptLoad = false;
                 }
@@ skipping 2643 matching lines @@
 }
 
 bool HTMLMediaElement::isLockedPendingUserGesture() const
 {
     return m_lockedPendingUserGesture;
 }
 
 void HTMLMediaElement::unlockUserGesture()
 {
     m_lockedPendingUserGesture = false;
+    m_unlockedUserGestureForMediaStream = false;
+}
+
+void HTMLMediaElement::lockUserGesture()
+{
+    m_lockedPendingUserGesture = needToLockPendingUserGesture(document());
+    m_unlockedUserGestureForMediaStream = false;
+}
+
+bool HTMLMediaElement::needToLockPendingUserGesture(const Document& document) const
+{
+    return (document.settings() && document.settings()->mediaPlaybackRequiresUserGesture())
+        || m_autoplayHelper->isExperimentEnabled();
 }
 
 bool HTMLMediaElement::isGestureNeededForPlayback() const
 {
     if (!m_lockedPendingUserGesture)
         return false;
 
     // We want to allow muted video to autoplay if:
     // - the flag is enabled;
     // - Data Saver is not enabled;
@@ skipping 272 matching lines @@
 
 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() const
 {
     IntRect result;
     if (LayoutObject* object = m_element->layoutObject())
         result = object->absoluteBoundingBoxRect();
     return result;
 }
 
 } // namespace blink