Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: Source/devtools/front_end/NetworkPanel.js

Issue 207553010: DevTools: speed up network scrolling and layout. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/DataGrid.js ('k') | Source/devtools/front_end/UIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/NetworkPanel.js
diff --git a/Source/devtools/front_end/NetworkPanel.js b/Source/devtools/front_end/NetworkPanel.js
index f7946ee378d121a22e5344510ad4f69e0f090f52..4cb9ead0006eec98116e30d152f196a8bd7b925f 100644
--- a/Source/devtools/front_end/NetworkPanel.js
+++ b/Source/devtools/front_end/NetworkPanel.js
@@ -184,11 +184,6 @@ WebInspector.NetworkLogView.prototype = {
return [this._dataGrid.scrollContainer];
},
- onResize: function()
- {
- this._updateOffscreenRows();
- },
-
_createTimelineGrid: function()
{
this._timelineGrid = new WebInspector.TimelineGrid();
@@ -325,7 +320,6 @@ WebInspector.NetworkLogView.prototype = {
// Event listeners need to be added _after_ we attach to the document, so that owner document is properly update.
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortItems, this);
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.ColumnsResized, this._updateDividersIfNeeded, this);
- this._dataGrid.scrollContainer.addEventListener("scroll", this._updateOffscreenRows.bind(this));
this._patchTimelineHeader();
},
@@ -429,7 +423,7 @@ WebInspector.NetworkLogView.prototype = {
this._dataGrid.sortNodes(sortingFunction, !this._dataGrid.isSortOrderAscending());
this._timelineSortSelector.selectedIndex = 0;
- this._updateOffscreenRows();
+ this._updateRows();
this.searchCanceled();
@@ -457,7 +451,7 @@ WebInspector.NetworkLogView.prototype = {
else
this._timelineGrid.showEventDividers();
this._dataGrid.markColumnAsSortedBy("timeline", WebInspector.DataGrid.Order.Ascending);
- this._updateOffscreenRows();
+ this._updateRows();
},
_createStatusBarItems: function()
@@ -912,7 +906,6 @@ WebInspector.NetworkLogView.prototype = {
this._timelineGrid.element.classList.remove("small");
}
this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.RowSizeChanged, { largeRows: enabled });
- this._updateOffscreenRows();
},
_getPopoverAnchor: function(element)
@@ -1154,7 +1147,7 @@ WebInspector.NetworkLogView.prototype = {
NetworkAgent.clearBrowserCookies();
},
- _updateOffscreenRows: function()
+ _updateRows: function()
{
var dataTableBody = this._dataGrid.dataTableBody;
var rows = dataTableBody.children;
@@ -1162,11 +1155,6 @@ WebInspector.NetworkLogView.prototype = {
if (recordsCount < 2)
return; // Filler row only.
- var visibleTop = this._dataGrid.scrollContainer.scrollTop;
- var visibleBottom = visibleTop + this._dataGrid.scrollContainer.offsetHeight;
-
- var rowHeight = 0;
-
// Filler is at recordsCount - 1.
var unfilteredRowIndex = 0;
for (var i = 0; i < recordsCount - 1; ++i) {
@@ -1178,14 +1166,6 @@ WebInspector.NetworkLogView.prototype = {
continue;
}
- if (!rowHeight)
- rowHeight = row.offsetHeight;
-
- var rowIsVisible = unfilteredRowIndex * rowHeight < visibleBottom && (unfilteredRowIndex + 1) * rowHeight > visibleTop;
- if (rowIsVisible !== row.rowIsVisible) {
- row.classList.toggle("offscreen", !rowIsVisible);
- row.rowIsVisible = rowIsVisible;
- }
var rowIsOdd = !!(unfilteredRowIndex & 1);
if (rowIsOdd !== row.rowIsOdd) {
row.classList.toggle("odd", rowIsOdd);
@@ -1403,7 +1383,7 @@ WebInspector.NetworkLogView.prototype = {
for (var i = 0; i < nodes.length; ++i)
this._applyFilter(nodes[i]);
this._updateSummaryBar();
- this._updateOffscreenRows();
+ this._updateRows();
},
jumpToPreviousSearchResult: function()
@@ -2383,8 +2363,6 @@ WebInspector.NetworkDataGridNode.prototype = {
/** override */
createCells: function()
{
- // Out of sight, out of mind: create nodes offscreen to save on render tree update times when running updateOffscreenRows()
- this._element.classList.add("offscreen");
this._nameCell = this._createDivInTD("name");
this._methodCell = this._createDivInTD("method");
this._statusCell = this._createDivInTD("status");
« no previous file with comments | « Source/devtools/front_end/DataGrid.js ('k') | Source/devtools/front_end/UIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698