Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 207553010: DevTools: speed up network scrolling and layout. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
eustas, alph
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: speed up network scrolling and layout. (still needs a lot of work) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170024

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -50 lines) Patch
M Source/devtools/front_end/DataGrid.js View 2 chunks +16 lines, -12 lines 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 10 chunks +4 lines, -26 lines 0 comments Download
M Source/devtools/front_end/UIUtils.js View 2 chunks +16 lines, -9 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/networkLogView.css View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-25 21:30:03 UTC) #1
alph
lgtm https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/NetworkPanel.js#newcode2366 Source/devtools/front_end/NetworkPanel.js:2366: // Out of sight, out of mind: create ...
6 years, 9 months ago (2014-03-25 22:07:24 UTC) #2
eustas
https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/DataGrid.js File Source/devtools/front_end/DataGrid.js (right): https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/DataGrid.js#newcode720 Source/devtools/front_end/DataGrid.js:720: for (var i = 0; i < numColumns - ...
6 years, 9 months ago (2014-03-26 04:46:48 UTC) #3
pfeldman
https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/DataGrid.js File Source/devtools/front_end/DataGrid.js (right): https://codereview.chromium.org/207553010/diff/40001/Source/devtools/front_end/DataGrid.js#newcode720 Source/devtools/front_end/DataGrid.js:720: for (var i = 0; i < numColumns - ...
6 years, 9 months ago (2014-03-26 05:00:56 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-26 05:29:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/207553010/130001
6 years, 9 months ago (2014-03-26 05:29:48 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 06:34:17 UTC) #7
Message was sent while issue was closed.
Change committed as 170024

Powered by Google App Engine
This is Rietveld 408576698