Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6284)

Unified Diff: chrome/common/net/net_error_info.h

Issue 207553008: Surface button for loading stale cache copy on net error page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync'd to r264192. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/net_error_info.h
diff --git a/chrome/common/net/net_error_info.h b/chrome/common/net/net_error_info.h
index 1f69f7cd36212e3d34563100c091ae3f2b3f3b42..de124eb285e2bd9c9b9cec95fcc06e1f6ef2f05b 100644
--- a/chrome/common/net/net_error_info.h
+++ b/chrome/common/net/net_error_info.h
@@ -7,6 +7,25 @@
namespace chrome_common_net {
+// Network error page events. Used for UMA statistics.
+enum NetworkErrorPageEvent {
+ NET_ERROR_PAGE_SHOWN, // Error pages shown.
sky 2014/04/17 15:26:54 I would prefer you followed the convention in cont
Randy Smith (Not in Mondays) 2014/04/17 16:04:54 My 80 columns!! :-} Done.
+
+ NET_ERROR_PAGE_RELOAD_BUTTON_SHOWN, // Reload buttons shown.
+ NET_ERROR_PAGE_RELOAD_BUTTON_CLICKED, // Reload button clicked.
+ NET_ERROR_PAGE_RELOAD_BUTTON_ERROR, // Reload button clicked -> error.
+
+ NET_ERROR_PAGE_LOAD_STALE_BUTTON_SHOWN, // Load stale buttons shown.
+ NET_ERROR_PAGE_LOAD_STALE_BUTTON_CLICKED, // Load stale button clicked.
+ NET_ERROR_PAGE_LOAD_STALE_BUTTON_ERROR, // Load stale buttons -> error.
+
+ NET_ERROR_PAGE_MORE_BUTTON_CLICKED, // More button clicked.
+
+ NET_ERROR_PAGE_BROWSER_INITIATED_RELOAD, // Reload initiated from browser.
+
+ NET_ERROR_PAGE_EVENT_MAX,
+};
+
// The status of a DNS probe that the NetErrorTabHelper may or may not have
// started.
//
@@ -62,6 +81,9 @@ const char* DnsProbeStatusToString(int status);
// Returns true if |status| is one of the DNS_PROBE_FINISHED_* statuses.
bool DnsProbeStatusIsFinished(DnsProbeStatus status);
+// Record specific error page events.
+void RecordEvent(NetworkErrorPageEvent event);
+
// The error domain used to pass DNS probe statuses to the localized error
// code.
extern const char kDnsProbeErrorDomain[];

Powered by Google App Engine
This is Rietveld 408576698