Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 207553008: Surface button for loading stale cache copy on net error page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make new functionality work transparently on IOS, which doesn't have gin bindings. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 6f1e60198071553bf9890c4d39adb4a41bdee403..ad1664d6aa6c0734e7c5cd65e0f9a95041108bad 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -60,13 +60,38 @@ function search(baseSearchUrl) {
return false;
}
+// Implements button clicks. This function is needed during the transition
+// between implementing these in trunk chromium and implementing them in
+// IOS.
+function reloadButtonClick(url) {
+ if ('errorPageController' in window) {
+ errorPageController.reloadButtonClick();
+ } else {
+ location = url;
+ }
+}
+
+function loadStaleButtonClick() {
+ if ('errorPageController' in window) {
+ errorPageController.loadStaleButtonClick();
+ }
+}
+
+function moreButtonClick() {
+ if ('errorPageController' in window) {
+ errorPageController.moreButtonClick();
+ }
mmenke 2014/04/15 16:02:25 nit: These all should be using two space indent.
mmenke 2014/04/15 16:02:25 Can't you just use: if (errorPageController) {
Randy Smith (Not in Mondays) 2014/04/15 18:27:29 Done.
Randy Smith (Not in Mondays) 2014/04/15 18:27:29 When I disable the Gin bindings (to mimc IOS) and
mmenke 2014/04/17 14:39:25 Ah, right. "window.errorPageController" would wor
Randy Smith (Not in Mondays) 2014/04/17 16:04:54 Huh. Learn something new every day; thank you. D
+}
+
<if expr="is_macosx or is_ios or is_linux or is_android">
// Re-orders buttons. Used on Mac, Linux, and Android, where reload should go
// on the right.
function swapButtonOrder() {
- reloadButton = document.getElementById('reload-button');
- moreLessButton = document.getElementById('more-less-button');
+ var reloadButton = document.getElementById('reload-button');
+ var moreLessButton = document.getElementById('more-less-button');
+ var staleLoadButton = document.getElementById('stale-load-button');
reloadButton.parentNode.insertBefore(moreLessButton, reloadButton);
+ reloadButton.parentNode.insertBefore(staleLoadButton, reloadButton)
}
document.addEventListener("DOMContentLoaded", swapButtonOrder);
</if>
« chrome/renderer/resources/neterror.html ('K') | « chrome/renderer/resources/neterror.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698