Surface button for loading stale cache copy on net error page.

chrome/common/net/net_error_info.h

Index: chrome/common/net/net_error_info.h
diff --git a/chrome/common/net/net_error_info.h b/chrome/common/net/net_error_info.h
index 1f69f7cd36212e3d34563100c091ae3f2b3f3b42..5746ae656605acf99dfcef5bc65b67970c209af4 100644
--- a/chrome/common/net/net_error_info.h
+++ b/chrome/common/net/net_error_info.h
@@ -7,6 +7,25 @@
 
 namespace chrome_common_net {
 
+// Network error page events.  Used for UMA statistics.
+enum NetworkErrorPageEvent {
+  NET_ERROR_PAGE_SHOWN,                 // Error pages shown.

[mmenke, 2014/04/15 16:02:25]

nit:  SHould probably line up all the comments.

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

Done.

+
+  NET_ERROR_PAGE_RELOAD_BUTTON_SHOWN,       // Reload buttons shown.
+  NET_ERROR_PAGE_RELOAD_BUTTON_CLICKED,     // Reload button clicks.
+  NET_ERROR_PAGE_RELOAD_BUTTON_ERROR,       // Reload button clicks -> error.

[mmenke, 2014/04/15 16:02:25]

For all of these comments, shouldn't "clicks" be "clicked"?

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

Done.

+
+  NET_ERROR_PAGE_LOAD_STALE_BUTTON_SHOWN,   // Load stale buttons shown.
+  NET_ERROR_PAGE_LOAD_STALE_BUTTON_CLICKED, // Load stale button clicks.

[mmenke, 2014/04/15 16:02:25]

Don't suppose there's space to indent these all two more?  Technically, should
be two spaces between code and comments.

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

I think I only need to indent one more to get two spaces, which I've done.

+  NET_ERROR_PAGE_LOAD_STALE_BUTTON_ERROR,   // Load stale buttons -> error.
+
+  NET_ERROR_PAGE_MORE_BUTTON_CLICKED,       // More button clicks.
+
+  NET_ERROR_PAGE_BROWSER_INITIATED_RELOAD, // Reload initiated from browser.

[mmenke, 2014/04/15 16:02:25]

nit:  +space before comment.

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

I'm assuming this is redundant with your other comments?  I don't see the need
once everything's been lined up. 

+
+  NET_ERROR_PAGE_EVENT_MAX,
+};
+
 // The status of a DNS probe that the NetErrorTabHelper may or may not have
 // started.
 //
@@ -62,6 +81,9 @@ const char* DnsProbeStatusToString(int status);
 // Returns true if |status| is one of the DNS_PROBE_FINISHED_* statuses.
 bool DnsProbeStatusIsFinished(DnsProbeStatus status);
 
+// Record specific error page events.
+void RecordEvent(NetworkErrorPageEvent event);
+
 // The error domain used to pass DNS probe statuses to the localized error
 // code.
 extern const char kDnsProbeErrorDomain[];