Surface button for loading stale cache copy on net error page.

chrome/browser/net/net_error_tab_helper.cc

Index: chrome/browser/net/net_error_tab_helper.cc
diff --git a/chrome/browser/net/net_error_tab_helper.cc b/chrome/browser/net/net_error_tab_helper.cc
index 7112321fa1fa0f2bb550fd08eb0dd71865743930..8ac52e23583bb219b5f8ab3528549c8f49644f39 100644
--- a/chrome/browser/net/net_error_tab_helper.cc
+++ b/chrome/browser/net/net_error_tab_helper.cc
@@ -76,6 +76,13 @@ void NetErrorTabHelper::set_state_for_testing(TestingState state) {
   testing_state_ = state;
 }
 
+void NetErrorTabHelper::NotifyBrowserReloading() {
+  // Record that we're doing a browser side reload on the error page.
+  if (is_error_page_)
+    chrome_common_net::RecordEvent(
+        chrome_common_net::BROWSER_RELOAD_BUTTON_CLICKED_EVENT);

[mmenke, 2014/04/11 19:42:32]

+braces.

[mmenke, 2014/04/11 19:42:32]

Does this record F5s?  What about right clicking and selecting reload?  Do we
care?  Not really sure what the purpose is here.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Whoops :-{.  Done.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

First, the facts: It captures F5, but not right click->selecting reload, I
presume because F5 goes through the browser and right click through the
renderer.

Then, the intent: My purpose is to figure out how often people use the reload
button on the error page versus "other" ways of reloading (loosely, gathering
data to see if we might want to nuke the reload button at some point.  

Ideally, I'd like to break out the different other ways to reload so that we
could understand what different people's "reload" instincts are.  But I don't
want to do more browser plumbing.  I consider it important to catch the right
click case, so I went digging, and it looks like the simplest way to get what I
want is to go with your suggestion of a PS or two back to hook
DidStartNavigationToPendingEntry(), and just dump all browser initiated
navigations in the same bin.  Done :-}.

+}
+
 void NetErrorTabHelper::DidStartProvisionalLoadForFrame(
     int64 frame_id,
     int64 parent_frame_id,