Surface button for loading stale cache copy on net error page.

chrome/renderer/net/net_error_page_controller.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_NET_NET_ERROR_PAGE_CONTROLLER_H_
+#define CHROME_RENDERER_NET_NET_ERROR_PAGE_CONTROLLER_H_
+
+#include "base/basictypes.h"

[mmenke, 2014/04/11 19:42:32]

Use macros.h instead (basictypes includes DISALLOW_COPY_AND_ASSIGN but not
OVERRIDE, I believe)

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

+#include "content/public/renderer/render_frame_observer.h"
+#include "gin/wrappable.h"
+#include "url/gurl.h"

[mmenke, 2014/04/11 19:42:32]

Not used.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

+
+// NetErrorPageController class:

[mmenke, 2014/04/11 19:42:32]

optional:  Think this is a little redundant.  Suggest replacing "this class"
with the class name, or just getting rid of this extra line.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

+//
+// This class makes cache loading operations available to the
+// error page loaded by NetErrorHelper.  It is bound to the javascript

[mmenke, 2014/04/11 19:42:32]

nit:  Javascript.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done (JavaScript).

+// window.errorCacheLoad object.

[mmenke, 2014/04/11 19:42:32]

These generally go right above the class, not the forward declarations

[mmenke, 2014/04/11 19:42:32]

The window.helperFunctions object, now.  window.errorPageController may be a
better name.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

+
+class GURL;

[mmenke, 2014/04/11 19:42:32]

Not used.

[Randy Smith (Not in Mondays), 2014/04/14 22:02:13]

Done.

+
+namespace content {
+class RenderFrame;
+}
+
+// Error page functions called from Javascript.
+class NetErrorPageController
+    : public gin::Wrappable<NetErrorPageController>,
+      public content::RenderFrameObserver {

[jochen (gone - plz use gerrit), 2014/04/14 07:32:35]

why do you derive from RFO?

[jochen (gone - plz use gerrit), 2014/04/14 13:11:53]

ah, I see that you're using RenderFrameObserver::render_frame()

[mmenke, 2014/04/14 14:05:46]

Yea, we're using the OnDestruct method, so we don't call into the render frame
after it's destroyed, since apparently this can both outlive render frame, and
some of its Click functions may be called after the render frame is destroyed (I
assume).

+ public:
+  static gin::WrapperInfo kWrapperInfo;
+
+  static void Install(content::RenderFrame* render_frame);
+
+ private:
+  explicit NetErrorPageController(content::RenderFrame* render_frame);
+  virtual ~NetErrorPageController();
+
+  // Execute a "Load Stale" button click.
+  bool LoadStaleButtonClick();
+
+  // Execute a "Reload" button click.
+  bool ReloadButtonClick();
+
+  // Execute a "More" button click.
+  bool MoreButtonClick();
+
+  // gin::WrappableBase
+  virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+      v8::Isolate* isolate) OVERRIDE;
+
+  // RenderFrameObserver.  Overridden to avoid being destroyed when RenderFrame
+  // goes away; NetErrorPageController objects are owned by the JS
+  // garbage collector.
+  virtual void OnDestruct() OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(NetErrorPageController);
+};
+
+#endif  // CHROME_RENDERER_NET_NET_ERROR_PAGE_CONTROLLER_H_