Surface button for loading stale cache copy on net error page.

chrome/renderer/net/error_page_helper_functions.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_NET_ERROR_CACHE_LOAD_H_
-#define CHROME_RENDERER_NET_ERROR_CACHE_LOAD_H_
+#ifndef CHROME_RENDERER_NET_ERROR_PAGE_HELPER_FUNCTIONS_H_
+#define CHROME_RENDERER_NET_ERROR_PAGE_HELPER_FUNCTIONS_H_
 
 #include "base/basictypes.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "gin/wrappable.h"
 #include "url/gurl.h"
 
-// ErrorCacheLoad class:
+// ErrorPageHelperFunctions class:
 //
 // This class makes cache loading operations available to the
 // error page loaded by NetErrorHelper.  It is bound to the javascript
 // window.errorCacheLoad object.
 
 class GURL;
 
 namespace content {
 class RenderFrame;
 }
 
-class ErrorCacheLoad : public gin::Wrappable<ErrorCacheLoad>,
-                       public content::RenderFrameObserver {
+class ErrorPageHelperFunctions

[mmenke, 2014/04/09 15:59:26]

Think NetErrorHelperFunctions to be more consistent or [Net]ErrorPageController
- a couple classes like this use controller, and
NetErrorPageFunctionsCalledFromJavascript seems a bit too long.  :)

[mmenke, 2014/04/09 15:59:26]

Think this is worth a comment (Error pages functions called from Javascript)

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Done.

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Done.

+    : public gin::Wrappable<ErrorPageHelperFunctions>,
+      public content::RenderFrameObserver {
  public:
   static gin::WrapperInfo kWrapperInfo;
 
   static void Install(content::RenderFrame* render_frame, const GURL& page_url);
 
  private:
-  ErrorCacheLoad(content::RenderFrame* render_frame, const GURL& page_url);
-  virtual ~ErrorCacheLoad();
+  ErrorPageHelperFunctions(content::RenderFrame* render_frame,
+                           const GURL& page_url);
+  virtual ~ErrorPageHelperFunctions();
 
-  // Loads the original URL associated with the frame, with the blink
-  // ReturnCacheDataDontLoad flag set to make sure that the value is
-  // only gotten from cache.
-  bool ReloadStaleInstance();
+  // Execute a "Load Stale" button click.
+  bool LoadStaleButtonClick();
+
+  // Execute a "Reload" button click.
+  bool ReloadButtonClick();
+
+  // Execute a "More" button click.
+  bool MoreButtonClick();
 
   // gin::WrappableBase
   virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
       v8::Isolate* isolate) OVERRIDE;
 
   // RenderFrameObserver.  Overridden to avoid being destroyed when RenderFrame
-  // goes away; ErrorCacheLoad objects are owned by the JS garbage collector.
+  // goes away; ErrorPageHelperFunctions objects are owned by the JS
+  // garbage collector.
   virtual void OnDestruct() OVERRIDE;
 
   // We'll be torn down by V8 when the page goes away, so it's safe to hold
   // a naked pointer to the render frame.
   content::RenderFrame* render_frame_;

[mmenke, 2014/04/09 15:59:26]

Don't need our own render_frame_:  render_frame() is NULLed out before destruct.

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Done.

 
   const GURL page_url_;

[mmenke, 2014/04/09 15:59:26]

Doesn't seem to be needed.

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Good catch.  Done.

 
   bool render_frame_destroyed_;

[mmenke, 2014/04/09 15:59:26]

Not used.

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Done.

 
-  DISALLOW_COPY_AND_ASSIGN(ErrorCacheLoad);
+  DISALLOW_COPY_AND_ASSIGN(ErrorPageHelperFunctions);
 };
 
-#endif  // CHROME_RENDERER_NET_ERROR_CACHE_LOAD_H_
+#endif  // CHROME_RENDERER_NET_ERROR_PAGE_HELPER_FUNCTIONS_H_