LayoutTests/fast/css/first-letter-punctuation.html - Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/first-letter-punctuation.html

Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from Eric: refactored code + more testing Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css-generated-content/quote-first-letter-expected.html ('K') | « LayoutTests/fast/css/first-letter-different-renderers-expected.html ('k') | LayoutTests/fast/css/first-letter-punctuation-expected.html » ('j') | Source/core/rendering/RenderBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style type="text/css">	4 <style type="text/css">

5 div:first-letter	5 div:first-letter

6 {	6 {

7 color: green;	7 color: green;

8 font-size: 36px;	8 font-size: 26px;
	mario.prada 2014/03/27 14:12:39 I reduced the font size here to make sure the whol I reduced the font size here to make sure the whole get page gets rendered without scrolling
9 }	9 }

10 </style>	10 </style>

11 </head>	11 </head>

12 <body>	12 <body>

13 <p>Test passes if all the T are green, as well as punctuation elements w hen they are adjacent to a letter (without spaces)</p>	13 <p>Test passes if all the T are green, as well as punctuation elements w hen they are adjacent to a letter (without spaces)</p>

14	14

15 <div>Test</div>	15 <div>Test</div>

16 <div> Test </div>	16 <div> Test </div>

17	17

18 <div>(T)est</div>	18 <div>(T)est</div>

	19 <div>(Test)</div>

19 <div> (T)est</div>	20 <div> (T)est</div>

	21 <div> (Test)</div>

	22

20 <div>“T”est</div>	23 <div>“T”est</div>

	24 <div>“Test”</div>

	25 <div><q>T</q>est</div>

	26 <div><q>Test</q></div>
	mario.prada 2014/03/27 14:12:39 I added some more cases in this test too to make s I added some more cases in this test too to make sure the code behaves properly when trailing punctuation should not be taken into account, and also with elements that will translate into plain text characters later on (<q>)
21	27

22 <div>&Test</div>	28 <div>&Test</div>

23 <div> &Test</div>	29 <div> &Test</div>

24 <div>T&S<div>	30 <div>T&S<div>

25 <div>T & S<div>	31 <div>T & S<div>

26 <div>T & S<div>	32 <div>T & S<div>

27	33

28 <div>« S »</div>	34 <div>« S »</div>

29 <div>« S »    </div>	35 <div>« S »    </div>

30	36

31 <div>• </div>	37 <div>• </div>

32 <div> •  </div>	38 <div> •  </div>

33 </body>	39 </body>

34 </html>	40 </html>

OLD	NEW