LayoutTests/fast/css-generated-content/quote-first-letter-expected.html - Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-generated-content/quote-first-letter-expected.html

Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from Eric: refactored code + more testing Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/editing/selection/extend-by-word-002.html ('K') | « LayoutTests/editing/selection/extend-by-word-002-expected.txt ('k') | LayoutTests/fast/css/first-letter-different-renderers.html » ('j') | LayoutTests/fast/css/first-letter-punctuation.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 .quote:first-letter { color: red; }	3 .line:first-letter { color: red; }
	mario.prada 2014/03/27 14:12:39 I needed to update this to line and remove the <sp I needed to update this to line and remove the <span class="quote"> below because now "'S" will become red because of the first-letter pseudo element used in the test over the following <span> element (and not just the quote): <span> <q>Should not crash or assert and all four quotes should be displayed.</q> </span>
4 .line { position: absolute; top: 50px; left: 10px; }	4 .line { position: absolute; top: 50px; left: 10px; }

5 </style>	5 </style>

6	6

7 " "	7 " "

8	8

9 <span class="line">	9 <span class="line">

10 <span class="quote">'</span>Should not crash or assert and all four quotes s hould be displayed.'	10 'Should not crash or assert and all four quotes should be displayed.'

11 </span>	11 </span>

OLD	NEW