LayoutTests/editing/selection/extend-by-word-002.html - Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/extend-by-word-002.html

Issue 207553007: Apply the correct style to first-letter pseudo elements composed of different renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from Eric: refactored code + more testing Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/editing/selection/extend-by-word-002-expected.txt » ('j') | LayoutTests/fast/css-generated-content/quote-first-letter-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3	3

4 <style>	4 <style>

5 .editing {	5 .editing {

6 border: 2px solid red;	6 border: 2px solid red;

7 padding: 12px;	7 padding: 12px;

8 font-size: 24px;	8 font-size: 24px;

9 }	9 }

10 .cell {	10 .cell {

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 range.setStart($("test").querySelectorAll("li")[0], 0);	58 range.setStart($("test").querySelectorAll("li")[0], 0);

59 var selection = window.getSelection();	59 var selection = window.getSelection();

60 selection.removeAllRanges();	60 selection.removeAllRanges();

61 selection.addRange(range);	61 selection.addRange(range);

62 for (var i = 0; i < 6; ++i)	62 for (var i = 0; i < 6; ++i)

63 selection.modify('extend', 'forward', 'word');	63 selection.modify('extend', 'forward', 'word');

64 shouldBeEqualToString('selection.type', 'Range');	64 shouldBeEqualToString('selection.type', 'Range');

65 shouldBe('selection.anchorNode', '$("test").querySelectorAll("li")[0].childNodes [0]');	65 shouldBe('selection.anchorNode', '$("test").querySelectorAll("li")[0].childNodes [0]');

66 shouldBe('selection.anchorOffset', '0');	66 shouldBe('selection.anchorOffset', '0');

67 shouldBe('selection.focusNode', '$("test").querySelectorAll("li a")[3].firstChil d');	67 shouldBe('selection.focusNode', '$("test").querySelectorAll("li a")[3].firstChil d');

68 shouldBe('selection.focusOffset', '4');	68 shouldBe('selection.focusOffset', '5');
	mario.prada 2014/03/27 14:12:39 This needs to be changed now because the starting This needs to be changed now because the starting point to calculate the offset is no longer inside of a generated RenderText element containing "teak..." (after splitting the original one into 2: "S" + "teak..."), but inside a RenderText element containing the whole "Steak & Ribs" text. Therefore, the expected offset now is 5, not 4
69 if (window.testRunner)	69 if (window.testRunner)

70 $('container').outerHTML = '';	70 $('container').outerHTML = '';

71 </script>	71 </script>

72 </body>	72 </body>

73 </html>	73 </html>

OLD	NEW