Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 207553005: TransitionElementsKind() and its recursive call chain handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

TransitionElementsKind() and its recursive call chain handlified. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20253

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing review notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -244 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/elements.cc View 3 chunks +14 lines, -50 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects.h View 5 chunks +8 lines, -13 lines 0 comments Download
M src/objects.cc View 1 11 chunks +105 lines, -161 lines 0 comments Download
M src/runtime.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-25 14:45:59 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/207553005/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/207553005/diff/1/src/objects.cc#newcode12730 src/objects.cc:12730: // Check if there is potentially ...
6 years, 9 months ago (2014-03-25 15:19:08 UTC) #2
Igor Sheludko
https://codereview.chromium.org/207553005/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/207553005/diff/1/src/objects.cc#newcode12730 src/objects.cc:12730: // Check if there is potentially a memento behind ...
6 years, 9 months ago (2014-03-25 15:27:45 UTC) #3
Igor Sheludko
6 years, 9 months ago (2014-03-25 15:33:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698